Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 2668733002: Update server generator (Closed)

Created:
3 years, 10 months ago by Brian Wilkerson
Modified:
3 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : re-ran generator #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -34 lines) Patch
M pkg/analysis_server/doc/api.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/plugin/protocol/generated_protocol.dart View 1 18 chunks +20 lines, -20 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_dart_protocol.dart View 2 chunks +13 lines, -6 lines 0 comments Download
M pkg/analysis_server/tool/spec/generated/java/types/NavigationTarget.java View 1 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 10 months ago (2017-01-31 16:23:27 UTC) #2
scheglov
LGTM
3 years, 10 months ago (2017-01-31 16:24:33 UTC) #3
Brian Wilkerson
3 years, 10 months ago (2017-01-31 16:26:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
fb5e367ca5b6cd6977bef77f18b768a8db06bf2f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698