Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 26687007: Ensure FakeAudioOutputStream runs on the WorkerLoop. (Closed)

Created:
7 years, 2 months ago by DaleCurtis
Modified:
7 years, 2 months ago
Reviewers:
miu
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Ensure FakeAudioOutputStream runs on the WorkerLoop. Otherwise we end up issuing IO calls on the UI thread for OSX when reading / writing to the SyncSocket. Additionally, these calls are high frequency enough that they shouldn't be on the UI thread. BUG=none TEST=ThreadRestrictions::AssertIOAllowed() can be used in SyncSocket. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229025

Patch Set 1 #

Patch Set 2 : Fix test and DCHECK. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M media/audio/audio_output_proxy_unittest.cc View 1 2 chunks +3 lines, -0 lines 0 comments Download
M media/audio/fake_audio_output_stream.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
DaleCurtis
7 years, 2 months ago (2013-10-16 00:41:06 UTC) #1
miu
lgtm
7 years, 2 months ago (2013-10-16 03:10:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/26687007/1
7 years, 2 months ago (2013-10-16 03:12:30 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) media_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=178068
7 years, 2 months ago (2013-10-16 04:26:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/26687007/27001
7 years, 2 months ago (2013-10-16 06:09:27 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=209163
7 years, 2 months ago (2013-10-16 07:46:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/26687007/27001
7 years, 2 months ago (2013-10-16 17:22:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/26687007/27001
7 years, 2 months ago (2013-10-16 20:44:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/26687007/27001
7 years, 2 months ago (2013-10-16 21:31:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/26687007/27001
7 years, 2 months ago (2013-10-17 01:42:36 UTC) #10
commit-bot: I haz the power
7 years, 2 months ago (2013-10-17 03:13:24 UTC) #11
Message was sent while issue was closed. 
Change committed as 229025

Powered by Google App Engine
This is Rietveld 408576698