[MD Bookmarks] Double Click

chrome/browser/resources/md_bookmarks/store.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var BookmarksStore = Polymer({
   is: 'bookmarks-store',
 
   properties: {
     /** @type {BookmarkTreeNode} */
     rootNode: {
@@ skipping 27 matching lines @@
     },
 
     /** @type {Object<?string, !BookmarkTreeNode>} */
     idToNodeMap_: Object,
 
     /** @type {?number} */
     anchorIndex_: Number,
 
     /** @type {Set<string>} */
     searchResultSet_: Object,
+
+    /** @type {Set<number>} */
+    selectedIndexSet_: Object,
   },
 
   /** @private {Object} */
   documentListeners_: null,
 
   /** @override */
   attached: function() {
     this.documentListeners_ = {
       'folder-open-changed': this.onFolderOpenChanged_.bind(this),
+      'open-item': this.onItemOpened_.bind(this),
       'search-term-changed': this.onSearchTermChanged_.bind(this),
       'select-item': this.onItemSelected_.bind(this),
       'selected-folder-changed': this.onSelectedFolderChanged_.bind(this),
     };
     for (var event in this.documentListeners_)
       document.addEventListener(event, this.documentListeners_[event]);
   },
 
   /** @override */
   detached: function() {
@@ skipping 18 matching lines @@
   // bookmarks-store, private:
 
   /**
    * @param {BookmarkTreeNode} rootNode
    * @private
    */
   setupStore_: function(rootNode) {
     this.rootNode = rootNode;
     this.idToNodeMap_ = {};
     this.rootNode.path = 'rootNode';
+    this.selectedIndexSet_ = new Set();
     BookmarksStore.generatePaths(rootNode, 0);
     BookmarksStore.initNodes(this.rootNode, this.idToNodeMap_);
 
     // Initialize the store's fields from the router.
     if (this.$.router.searchTerm)
       this.searchTerm = this.$.router.searchTerm;
     else
       this.fire('selected-folder-changed', this.$.router.selectedId);
   },
 
@@ skipping 75 matching lines @@
   },
 
   /**
    * Remove all selected items in the list.
    * @private
    */
   clearSelectedItems_: function() {
     if (!this.displayedList)
       return;
 
+    this.selectedIndexSet_.clear();
+
     for (var i = 0; i < this.displayedList.length; i++) {
       if (!this.displayedList[i].isSelectedItem)
         continue;
 
       this.set('displayedList.#' + i + '.isSelectedItem', false);
     }
   },
 
   /**
    * Return the index in the search result of an item.
@@ skipping 43 matching lines @@
     var startIndex, endIndex;
     if (this.anchorIndex_ == null) {
       this.anchorIndex_ = this.getIndexInList_(item);
       startIndex = this.anchorIndex_;
       endIndex = this.anchorIndex_;
     } else {
       var selectedIndex = this.getIndexInList_(item);
       startIndex = Math.min(this.anchorIndex_, selectedIndex);
       endIndex = Math.max(this.anchorIndex_, selectedIndex);
     }
-    for (var i = startIndex; i <= endIndex; i++)
+    for (var i = startIndex; i <= endIndex; i++) {
       this.set('displayedList.#' + i + '.isSelectedItem', true);
+      this.selectedIndexSet_.add(i);
+    }
   },
 
   /**
    * Selects a single item in the displayedList.
    * @param {BookmarkTreeNode} item
    * @private
    */
   selectItem_: function(item) {
     this.anchorIndex_ = this.getIndexInList_(item);
     this.set('displayedList.#' + this.anchorIndex_ + '.isSelectedItem', true);
+    this.selectedIndexSet_.add(this.anchorIndex_);
   },
 
   //////////////////////////////////////////////////////////////////////////////
   // bookmarks-store, bookmarks API event listeners:
 
   /**
    * Callback for when a bookmark node is removed.
    * If a folder is selected or is an ancestor of a selected folder, the parent
    * of the removed folder will be selected.
    * @param {string} id The id of the removed bookmark node.
@@ skipping 78 matching lines @@
     // Deselect the old folder if defined.
     if (this.selectedId && this.idToNodeMap_[this.selectedId])
       this.set(
           this.idToNodeMap_[this.selectedId].path + '.isSelectedFolder', false);
 
     // Check if the selected id is that of a defined folder.
     var id = /** @type {string} */ (e.detail);
     if (!this.idToNodeMap_[id] || this.idToNodeMap_[id].url)
       id = this.rootNode.children[0].id;
 
-    var newFolder = this.idToNodeMap_[id];
-    this.set(newFolder.path + '.isSelectedFolder', true);
+    var folder = this.idToNodeMap_[id];
+    this.set(folder.path + '.isSelectedFolder', true);
     this.selectedId = id;
+    while (folder.parentId) {
+      folder = this.idToNodeMap_[folder.parentId];
+      if (folder.isOpen)
+        continue;
+
+      this.fire('folder-open-changed', {
+        id: folder.id,
+        open: true,
+      });
+    }
   },
 
   /**
    * Handles events that open and close folders.
    * @param {CustomEvent} e
    * @private
    */
   onFolderOpenChanged_: function(e) {
     var folder = this.idToNodeMap_[e.detail.id];
     this.set(folder.path + '.isOpen', e.detail.open);
     if (!folder.isOpen && this.isAncestorOfSelected_(folder))
       this.fire('selected-folder-changed', folder.id);
   },
 
   /**
    * Selects items according to keyboard behaviours.
    * @param {CustomEvent} e
    * @private
    */
   onItemSelected_: function(e) {
     if (!e.detail.add)
       this.clearSelectedItems_();
 
     if (e.detail.range)
       this.selectRange_(e.detail.item);
     else
       this.selectItem_(e.detail.item);
   },
+
+  /**
+   * @param {CustomEvent} e
+   * @private
+   */
+  onItemOpened_: function(e) {
+    if (this.selectedIndexSet_.size == 1) {
+      var item = /** BookmarkTreeNode */ (e.detail);
+      // do the single event here
+      if (!item.url)
+        this.fire('selected-folder-changed', item.id);
+      else
+        chrome.tabs.create({url: item.url});
+    } else {
+      for (let index of this.selectedIndexSet_) {

[tsergeant, 2017/02/02 02:02:38]

Chris and I just tried the old bookmark manager and it seems like double
clicking an item when you've got multiple items selected just opens the one
you're clicking on.

It seems good to just do the basics for now in the interest of getting this in
before the end of the internship. If you get time, we can come back and do the
more complex behavior.

If you just want to do the simple behavior, you probably don't need to add this
new event in store -- you can just call tabs.create or selected-folder-changed
from list directly.

[jiaxi, 2017/02/02 03:07:03]

Done.

+        if (!this.displayedList[index].url)
+          continue;
+
+        chrome.tabs.create({url: this.displayedList[index].url});
+      }
+    }
+  },
 });
 
 ////////////////////////////////////////////////////////////////////////////////
 // bookmarks-store, static methods:
 
 /**
  * Stores the path from the store to a node inside the node.
  * @param {BookmarkTreeNode} bookmarkNode
  * @param {number} startIndex
  */
@@ skipping 21 matching lines @@
     idToNodeMap[bookmarkNode.id] = bookmarkNode;
 
   if (bookmarkNode.url)
     return;
 
   bookmarkNode.isSelectedFolder = false;
   bookmarkNode.isOpen = true;
   for (var i = 0; i < bookmarkNode.children.length; i++)
     BookmarksStore.initNodes(bookmarkNode.children[i], idToNodeMap);
 };