Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: chrome/test/data/webui/settings/settings_passwords_section_browsertest.js

Issue 2668623002: MD Settings: Fix remaining tests that fail in Vulcanized mode. (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/settings/settings_passwords_section_browsertest.js
diff --git a/chrome/test/data/webui/settings/settings_passwords_section_browsertest.js b/chrome/test/data/webui/settings/settings_passwords_section_browsertest.js
index 5efab4cb342de3f677290d981d1ce7ab855fb61e..b714d60776037c74d9b6d04614b0b1fa2a9049ef 100644
--- a/chrome/test/data/webui/settings/settings_passwords_section_browsertest.js
+++ b/chrome/test/data/webui/settings/settings_passwords_section_browsertest.js
@@ -34,6 +34,7 @@ SettingsPasswordSectionBrowserTest.prototype = {
/** @override */
setUp: function() {
PolymerTest.prototype.setUp.call(this);
+ PolymerTest.clearBody();
// Test is run on an individual element that won't have a page language.
this.accessibilityAuditConfig.auditRulesToIgnore.push('humanLangMissing');
@@ -170,7 +171,8 @@ TEST_F('SettingsPasswordSectionBrowserTest', 'uiTests', function() {
suite('PasswordsSection', function() {
test('verifyNoSavedPasswords', function() {
- assertEquals(self.browsePreload, document.location.href);
+ // TODO(dpapad): This assertion does not make sense in vulcanized mode.
+ //assertEquals(self.browsePreload, document.location.href);
Dan Beam 2017/02/03 22:49:08 remove it, maybe? is this because of the <base> t
var passwordsSection = self.createPasswordsSection_([], []);
@@ -181,7 +183,8 @@ TEST_F('SettingsPasswordSectionBrowserTest', 'uiTests', function() {
});
test('verifySavedPasswordLength', function() {
- assertEquals(self.browsePreload, document.location.href);
+ // TODO(dpapad): This assertion does not make sense in vulcanized mode.
+ //assertEquals(self.browsePreload, document.location.href);
var passwordList = [
FakeDataMaker.passwordEntry('site1.com', 'luigi', 1),

Powered by Google App Engine
This is Rietveld 408576698