Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: src/inspector/v8-debugger.cc

Issue 2668613002: [inspector] added Debugger.moduleRequested notification
Patch Set: addressed comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/inspector/v8-debugger.cc
diff --git a/src/inspector/v8-debugger.cc b/src/inspector/v8-debugger.cc
index f4980e2f87e1de3d4916b2c526dd7c2c0d107b3b..f8c089d24864dac2fb78a295d12ebf710310af5b 100644
--- a/src/inspector/v8-debugger.cc
+++ b/src/inspector/v8-debugger.cc
@@ -126,6 +126,10 @@ void V8Debugger::getCompiledScripts(
}
}
+void V8Debugger::reportExistingModules() {
+ v8::debug::ReportExistingModules(m_isolate);
+}
+
String16 V8Debugger::setBreakpoint(const ScriptBreakpoint& breakpoint,
int* actualLineNumber,
int* actualColumnNumber) {
@@ -566,6 +570,17 @@ bool V8Debugger::IsFunctionBlackboxed(v8::Local<v8::debug::Script> script,
end);
}
+void V8Debugger::ModuleResolved(v8::Local<v8::debug::Script> referer,
+ v8::Local<v8::debug::Script> requested,
+ v8::Local<v8::String> specifier) {
+ V8DebuggerAgentImpl* refererAgent = agentForScript(m_inspector, referer);
+ V8DebuggerAgentImpl* requestedAgent = agentForScript(m_inspector, requested);
+ if (refererAgent != requestedAgent) return;
+ refererAgent->moduleResolved(String16::fromInteger(referer->Id()),
+ String16::fromInteger(requested->Id()),
+ toProtocolString(specifier));
+}
+
void V8Debugger::PromiseEventOccurred(v8::debug::PromiseDebugActionType type,
int id, int parentId) {
if (!m_maxAsyncCallStackDepth) return;

Powered by Google App Engine
This is Rietveld 408576698