Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1192)

Unified Diff: content/browser/loader/resource_dispatcher_host_unittest.cc

Issue 2668603003: Make ResourceHandler::OnWillRead able to complete asynchronously. (Closed)
Patch Set: Response to comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/resource_dispatcher_host_unittest.cc
diff --git a/content/browser/loader/resource_dispatcher_host_unittest.cc b/content/browser/loader/resource_dispatcher_host_unittest.cc
index b1a2e012d87e419d6c816ff41ee4d9ecfe74de43..aa7b57b8aebe11118b27a0d74da5fd4ac184140a 100644
--- a/content/browser/loader/resource_dispatcher_host_unittest.cc
+++ b/content/browser/loader/resource_dispatcher_host_unittest.cc
@@ -2429,15 +2429,14 @@ TEST_P(ResourceDispatcherHostTest, TooManyOutstandingRequests) {
for (size_t i = 0; i < kMaxRequestsPerProcess; ++i)
CheckSuccessfulRequest(msgs[i], net::URLRequestTestJob::test_data_2());
- // TODO(mmenke): These should be failing with ERR_INSUFFICIENT_RESOURCES.
- // Update OnWillRead to use a ResourceController so it can fail with different
- // error codes.
CheckFailedRequest(msgs[kMaxRequestsPerProcess + 0],
- net::URLRequestTestJob::test_data_2(), net::ERR_ABORTED);
+ net::URLRequestTestJob::test_data_2(),
+ net::ERR_INSUFFICIENT_RESOURCES);
CheckSuccessfulRequest(msgs[kMaxRequestsPerProcess + 1],
net::URLRequestTestJob::test_data_2());
CheckFailedRequest(msgs[kMaxRequestsPerProcess + 2],
- net::URLRequestTestJob::test_data_2(), net::ERR_ABORTED);
+ net::URLRequestTestJob::test_data_2(),
+ net::ERR_INSUFFICIENT_RESOURCES);
second_filter->OnChannelClosing();
third_filter->OnChannelClosing();
« no previous file with comments | « content/browser/loader/redirect_to_file_resource_handler.cc ('k') | content/browser/loader/resource_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698