content/browser/loader/mojo_async_resource_handler_unittest.cc - Issue 2668603003: Make ResourceHandler::OnWillRead able to complete asynchronously.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/mojo_async_resource_handler_unittest.cc

Issue 2668603003: Make ResourceHandler::OnWillRead able to complete asynchronously. (Closed)

Patch Set: Response to comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/loader/mojo_async_resource_handler_unittest.cc

diff --git a/content/browser/loader/mojo_async_resource_handler_unittest.cc b/content/browser/loader/mojo_async_resource_handler_unittest.cc

index fc47d15c629f5e77e4cc3f47ba01dc637b0056c6..d9f474e24414e9f63e24913a389ef0ef504ef6be 100644

--- a/content/browser/loader/mojo_async_resource_handler_unittest.cc

+++ b/content/browser/loader/mojo_async_resource_handler_unittest.cc

@@ -536,8 +536,7 @@ TEST_F(MojoAsyncResourceHandlerTest, OnWillReadWithInsufficientResource) {

ASSERT_TRUE(CallOnWillStartAndOnResponseStarted());

ASSERT_EQ(MockResourceLoader::Status::CANCELED, mock_loader_->OnWillRead());

- // TODO(mmenke): Make this fail with net::ERR_INSUFFICIENT_RESOURCES.

- EXPECT_EQ(net::ERR_ABORTED, mock_loader_->error_code());

+ EXPECT_EQ(net::ERR_INSUFFICIENT_RESOURCES, mock_loader_->error_code());

EXPECT_EQ(1, rdh_.num_in_flight_requests_for_testing());

handler_ = nullptr;

EXPECT_EQ(0, rdh_.num_in_flight_requests_for_testing());