Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Unified Diff: content/browser/download/save_file_resource_handler.cc

Issue 2668603003: Make ResourceHandler::OnWillRead able to complete asynchronously. (Closed)
Patch Set: Response to comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/save_file_resource_handler.cc
diff --git a/content/browser/download/save_file_resource_handler.cc b/content/browser/download/save_file_resource_handler.cc
index efea74fb3cc556345c2207a21ab2d72660f154de..98b332de01c3998bdf7fa2aa7a9db292cdcc87b7 100644
--- a/content/browser/download/save_file_resource_handler.cc
+++ b/content/browser/download/save_file_resource_handler.cc
@@ -70,8 +70,10 @@ void SaveFileResourceHandler::OnWillStart(
}
}
-bool SaveFileResourceHandler::OnWillRead(scoped_refptr<net::IOBuffer>* buf,
- int* buf_size) {
+void SaveFileResourceHandler::OnWillRead(
+ scoped_refptr<net::IOBuffer>* buf,
+ int* buf_size,
+ std::unique_ptr<ResourceController> controller) {
DCHECK_EQ(AuthorizationState::AUTHORIZED, authorization_state_);
DCHECK(buf && buf_size);
if (!read_buffer_.get()) {
@@ -79,7 +81,7 @@ bool SaveFileResourceHandler::OnWillRead(scoped_refptr<net::IOBuffer>* buf,
read_buffer_ = new net::IOBuffer(*buf_size);
}
*buf = read_buffer_.get();
- return true;
+ controller->Resume();
}
void SaveFileResourceHandler::OnReadCompleted(
« no previous file with comments | « content/browser/download/save_file_resource_handler.h ('k') | content/browser/loader/async_resource_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698