content/browser/loader/sync_resource_handler.h - Issue 2668603003: Make ResourceHandler::OnWillRead able to complete asynchronously.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/sync_resource_handler.h

Issue 2668603003: Make ResourceHandler::OnWillRead able to complete asynchronously. (Closed)

Patch Set: One bot doesn't like 256 day timers. :( Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/loader/sync_resource_handler.h

diff --git a/content/browser/loader/sync_resource_handler.h b/content/browser/loader/sync_resource_handler.h

index 38fa4160fbe0a7291e17cbb4900a3d00559f8db9..881be7f6e76f640860d4343ee198e1f310fd244b 100644

--- a/content/browser/loader/sync_resource_handler.h

+++ b/content/browser/loader/sync_resource_handler.h

@@ -42,8 +42,9 @@ class SyncResourceHandler : public ResourceHandler {

std::unique_ptr<ResourceController> controller) override;

void OnWillStart(const GURL& url,

std::unique_ptr<ResourceController> controller) override;

- bool OnWillRead(scoped_refptr<net::IOBuffer>* buf,

- int* buf_size) override;

+ void OnWillRead(scoped_refptr<net::IOBuffer>* buf,

+ int* buf_size,

+ std::unique_ptr<ResourceController> controller) override;

void OnReadCompleted(int bytes_read,

std::unique_ptr<ResourceController> controller) override;

void OnResponseCompleted(