Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Side by Side Diff: content/browser/loader/sync_resource_handler.cc

Issue 2668603003: Make ResourceHandler::OnWillRead able to complete asynchronously. (Closed)
Patch Set: Response to comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/loader/sync_resource_handler.h" 5 #include "content/browser/loader/sync_resource_handler.h"
6 6
7 #include "base/callback_helpers.h" 7 #include "base/callback_helpers.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "content/browser/loader/netlog_observer.h" 9 #include "content/browser/loader/netlog_observer.h"
10 #include "content/browser/loader/resource_controller.h" 10 #include "content/browser/loader/resource_controller.h"
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 result_.devtools_info = response->head.devtools_info; 89 result_.devtools_info = response->head.devtools_info;
90 controller->Resume(); 90 controller->Resume();
91 } 91 }
92 92
93 void SyncResourceHandler::OnWillStart( 93 void SyncResourceHandler::OnWillStart(
94 const GURL& url, 94 const GURL& url,
95 std::unique_ptr<ResourceController> controller) { 95 std::unique_ptr<ResourceController> controller) {
96 controller->Resume(); 96 controller->Resume();
97 } 97 }
98 98
99 bool SyncResourceHandler::OnWillRead(scoped_refptr<net::IOBuffer>* buf, 99 void SyncResourceHandler::OnWillRead(
100 int* buf_size) { 100 scoped_refptr<net::IOBuffer>* buf,
101 int* buf_size,
102 std::unique_ptr<ResourceController> controller) {
101 *buf = read_buffer_.get(); 103 *buf = read_buffer_.get();
102 *buf_size = kReadBufSize; 104 *buf_size = kReadBufSize;
103 return true; 105 controller->Resume();
104 } 106 }
105 107
106 void SyncResourceHandler::OnReadCompleted( 108 void SyncResourceHandler::OnReadCompleted(
107 int bytes_read, 109 int bytes_read,
108 std::unique_ptr<ResourceController> controller) { 110 std::unique_ptr<ResourceController> controller) {
109 if (bytes_read) 111 if (bytes_read)
110 result_.data.append(read_buffer_->data(), bytes_read); 112 result_.data.append(read_buffer_->data(), bytes_read);
111 controller->Resume(); 113 controller->Resume();
112 } 114 }
113 115
(...skipping 10 matching lines...) Expand all
124 126
125 controller->Resume(); 127 controller->Resume();
126 } 128 }
127 129
128 void SyncResourceHandler::OnDataDownloaded(int bytes_downloaded) { 130 void SyncResourceHandler::OnDataDownloaded(int bytes_downloaded) {
129 // Sync requests don't involve ResourceMsg_DataDownloaded messages 131 // Sync requests don't involve ResourceMsg_DataDownloaded messages
130 // being sent back to renderers as progress is made. 132 // being sent back to renderers as progress is made.
131 } 133 }
132 134
133 } // namespace content 135 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/loader/sync_resource_handler.h ('k') | content/browser/loader/test_resource_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698