Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Side by Side Diff: content/browser/loader/stream_resource_handler.cc

Issue 2668603003: Make ResourceHandler::OnWillRead able to complete asynchronously. (Closed)
Patch Set: Response to comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/loader/stream_resource_handler.h" 5 #include "content/browser/loader/stream_resource_handler.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "content/browser/loader/resource_controller.h" 9 #include "content/browser/loader/resource_controller.h"
10 #include "net/url_request/url_request_status.h" 10 #include "net/url_request/url_request_status.h"
(...skipping 25 matching lines...) Expand all
36 std::unique_ptr<ResourceController> controller) { 36 std::unique_ptr<ResourceController> controller) {
37 controller->Resume(); 37 controller->Resume();
38 } 38 }
39 39
40 void StreamResourceHandler::OnWillStart( 40 void StreamResourceHandler::OnWillStart(
41 const GURL& url, 41 const GURL& url,
42 std::unique_ptr<ResourceController> controller) { 42 std::unique_ptr<ResourceController> controller) {
43 controller->Resume(); 43 controller->Resume();
44 } 44 }
45 45
46 bool StreamResourceHandler::OnWillRead(scoped_refptr<net::IOBuffer>* buf, 46 void StreamResourceHandler::OnWillRead(
47 int* buf_size) { 47 scoped_refptr<net::IOBuffer>* buf,
48 int* buf_size,
49 std::unique_ptr<ResourceController> controller) {
48 writer_.OnWillRead(buf, buf_size, -1); 50 writer_.OnWillRead(buf, buf_size, -1);
49 return true; 51 controller->Resume();
50 } 52 }
51 53
52 void StreamResourceHandler::OnReadCompleted( 54 void StreamResourceHandler::OnReadCompleted(
53 int bytes_read, 55 int bytes_read,
54 std::unique_ptr<ResourceController> controller) { 56 std::unique_ptr<ResourceController> controller) {
55 writer_.OnReadCompleted(bytes_read, 57 writer_.OnReadCompleted(bytes_read,
56 base::Bind(&ResourceController::Resume, 58 base::Bind(&ResourceController::Resume,
57 base::Passed(std::move(controller)))); 59 base::Passed(std::move(controller))));
58 } 60 }
59 61
60 void StreamResourceHandler::OnResponseCompleted( 62 void StreamResourceHandler::OnResponseCompleted(
61 const net::URLRequestStatus& status, 63 const net::URLRequestStatus& status,
62 std::unique_ptr<ResourceController> controller) { 64 std::unique_ptr<ResourceController> controller) {
63 writer_.Finalize(status.error()); 65 writer_.Finalize(status.error());
64 controller->Resume(); 66 controller->Resume();
65 } 67 }
66 68
67 void StreamResourceHandler::OnDataDownloaded(int bytes_downloaded) { 69 void StreamResourceHandler::OnDataDownloaded(int bytes_downloaded) {
68 NOTREACHED(); 70 NOTREACHED();
69 } 71 }
70 72
71 } // namespace content 73 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/loader/stream_resource_handler.h ('k') | content/browser/loader/sync_resource_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698