[Android] Further speculative fixes for search engine crashes.

chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java

Index: chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java b/chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java
index 2bdbd77874b955fc7b1b087e8291f9a11d333aba..2866f96b6d04945dfdeb6712da144e37daacb354 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java
@@ -16,6 +16,7 @@ import java.lang.annotation.Retention;
 import java.lang.annotation.RetentionPolicy;
 import java.util.ArrayList;
 import java.util.List;
+import java.util.Locale;
 
 /**
  * Android wrapper of the TemplateUrlService which provides access from the Java
@@ -68,8 +69,8 @@ public class TemplateUrlService {
 
         @CalledByNative("TemplateUrl")
         public static TemplateUrl create(
-                int id, String shortName, boolean isPrepopulated, String keyword) {
-            return new TemplateUrl(id, shortName, isPrepopulated, keyword);
+                int index, String shortName, boolean isPrepopulated, String keyword) {
+            return new TemplateUrl(index, shortName, isPrepopulated, keyword);
         }
 
         public TemplateUrl(
@@ -119,8 +120,19 @@ public class TemplateUrlService {
             if (!(other instanceof TemplateUrl)) return false;
             TemplateUrl otherTemplateUrl = (TemplateUrl) other;
             return mIndex == otherTemplateUrl.mIndex
+                    && mIsPrepopulated == otherTemplateUrl.mIsPrepopulated
+                    && mTemplateUrlType == otherTemplateUrl.mTemplateUrlType

[Ted C, 2017/01/31 00:54:34]

had to remove mTemplateUrlType because that changes if you make a search engine
a default

+                    && TextUtils.equals(mKeyword, otherTemplateUrl.mKeyword)
                     && TextUtils.equals(mShortName, otherTemplateUrl.mShortName);
         }
+
+        @Override
+        public String toString() {
+            return String.format(Locale.US,
+                    "TemplateURL -- keyword: %s, short name: %s, index: %d, "
+                    + "type: %d, prepopulated: %b",
+                    mKeyword, mShortName, mIndex, mTemplateUrlType, mIsPrepopulated);
+        }
     }
 
     private static TemplateUrlService sService;