[Android] Further speculative fixes for search engine crashes.

chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.preferences;
 
 import android.content.Context;
 import android.content.Intent;
 import android.content.SharedPreferences;
 import android.content.res.Resources;
 import android.os.Build;
 import android.os.Bundle;
 import android.text.SpannableString;
 import android.text.style.ForegroundColorSpan;
 import android.view.LayoutInflater;
 import android.view.View;
 import android.view.View.AccessibilityDelegate;
 import android.view.View.OnClickListener;
 import android.view.ViewGroup;
 import android.view.accessibility.AccessibilityEvent;
 import android.view.accessibility.AccessibilityNodeInfo;
 import android.widget.BaseAdapter;
 import android.widget.RadioButton;
 import android.widget.TextView;
 
 import org.chromium.base.ApiCompatibilityUtils;
 import org.chromium.base.ContextUtils;
+import org.chromium.base.Log;
 import org.chromium.base.VisibleForTesting;
 import org.chromium.base.metrics.RecordUserAction;
 import org.chromium.chrome.R;
 import org.chromium.chrome.browser.ChromeFeatureList;
 import org.chromium.chrome.browser.locale.LocaleManager;
 import org.chromium.chrome.browser.omnibox.geo.GeolocationHeader;
 import org.chromium.chrome.browser.preferences.website.ContentSetting;
 import org.chromium.chrome.browser.preferences.website.GeolocationInfo;
 import org.chromium.chrome.browser.preferences.website.SingleWebsitePreferences;
 import org.chromium.chrome.browser.preferences.website.WebsitePreferenceBridge;
 import org.chromium.chrome.browser.search_engines.TemplateUrlService;
 import org.chromium.chrome.browser.search_engines.TemplateUrlService.TemplateUrl;
 import org.chromium.components.location.LocationUtils;
 import org.chromium.ui.text.SpanApplier;
 import org.chromium.ui.text.SpanApplier.SpanInfo;
 
 import java.util.ArrayList;
 import java.util.List;
 
 /**
 * A custom adapter for listing search engines.
 */
 public class SearchEngineAdapter extends BaseAdapter
         implements TemplateUrlService.LoadListener, TemplateUrlService.TemplateUrlServiceObserver,
                 OnClickListener {
+    private static final String TAG = "cr_SearchEngines";
+
     private static final int VIEW_TYPE_ITEM = 0;
     private static final int VIEW_TYPE_DIVIDER = 1;
     private static final int VIEW_TYPE_COUNT = 2;
 
     /** The current context. */
     private Context mContext;
 
     /** The layout inflater to use for the custom views. */
     private LayoutInflater mLayoutInflater;
 
@@ skipping 178 matching lines @@
         if (position == mPrepopulatedSearchEngines.size() && mRecentSearchEngines.size() != 0) {
             return VIEW_TYPE_DIVIDER;
         } else {
             return VIEW_TYPE_ITEM;
         }
     }
 
     @Override
     public View getView(int position, View convertView, ViewGroup parent) {
         View view = convertView;
-        TemplateUrl templateUrl = (TemplateUrl) getItem(position);
         int itemViewType = getItemViewType(position);
         if (convertView == null) {
             view = mLayoutInflater.inflate(
                     itemViewType == VIEW_TYPE_DIVIDER && mRecentSearchEngines.size() != 0
                             ? R.layout.search_engine_recent_title
                             : R.layout.search_engine,
                     null);
         }
         if (itemViewType == VIEW_TYPE_DIVIDER) {
             return view;
@@ skipping 11 matching lines @@
         // TODO(finnur): Remove the encompassing if statement once we go back to using the AppCompat
         // control.
         final boolean selected = position == mSelectedSearchEnginePosition;
         if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) {
             radioButton.setBackgroundResource(0);
         }
         radioButton.setChecked(selected);
 
         TextView description = (TextView) view.findViewById(R.id.name);
         Resources resources = mContext.getResources();
+
+        TemplateUrl templateUrl = (TemplateUrl) getItem(position);
         description.setText(templateUrl.getShortName());
 
         TextView url = (TextView) view.findViewById(R.id.url);
         url.setText(templateUrl.getKeyword());
         if (templateUrl.getType() == TemplateUrlService.TYPE_PREPOPULATED
                 || templateUrl.getType() == TemplateUrlService.TYPE_DEFAULT
                 || templateUrl.getKeyword().length() == 0) {
             url.setVisibility(View.GONE);
         }
 
@@ skipping 11 matching lines @@
             @Override
             public void onInitializeAccessibilityNodeInfo(View host, AccessibilityNodeInfo info) {
                 super.onInitializeAccessibilityNodeInfo(host, info);
                 info.setCheckable(true);
                 info.setChecked(selected);
             }
         });
 
         TextView link = (TextView) view.findViewById(R.id.location_permission);
         link.setVisibility(selected ? View.VISIBLE : View.GONE);
-        if (selected) {
-            if (getLocationPermissionType(position, true) == ContentSetting.ASK) {
+        if (TemplateUrlService.getInstance().getSearchEngineUrlFromTemplateUrl(
+                templateUrl.getKeyword()) == null) {
+            Log.e(TAG, "Invalid template URL found: %s", templateUrl);
+            assert false;
+            link.setVisibility(View.GONE);
+        } else if (selected) {
+            if (getLocationPermissionType(templateUrl, true) == ContentSetting.ASK) {
                 link.setVisibility(View.GONE);
             } else {
                 ForegroundColorSpan linkSpan = new ForegroundColorSpan(
                         ApiCompatibilityUtils.getColor(resources, R.color.google_blue_700));
                 if (LocationUtils.getInstance().isSystemLocationSettingEnabled()) {
                     String message = mContext.getString(
-                            locationEnabled(position, true)
+                            locationEnabled(templateUrl, true)
                             ? R.string.search_engine_location_allowed
                             : R.string.search_engine_location_blocked);
                     SpannableString messageWithLink = new SpannableString(message);
                     messageWithLink.setSpan(linkSpan, 0, messageWithLink.length(), 0);
                     link.setText(messageWithLink);
                 } else {
                     link.setText(SpanApplier.applySpans(
                             mContext.getString(R.string.android_location_off),
                             new SpanInfo("<link>", "</link>", linkSpan)));
                 }
@@ skipping 29 matching lines @@
             searchEngineSelected((int) view.getTag());
         }
     }
 
     private String searchEngineSelected(int position) {
         // First clean up any automatically added permissions (if any) for the previously selected
         // search engine.
         SharedPreferences sharedPreferences =
                 ContextUtils.getAppSharedPreferences();
         if (sharedPreferences.getBoolean(PrefServiceBridge.LOCATION_AUTO_ALLOWED, false)) {
-            if (locationEnabled(mSelectedSearchEnginePosition, false)) {
+            TemplateUrl templateUrl = (TemplateUrl) getItem(mSelectedSearchEnginePosition);
+            if (locationEnabled(templateUrl, false)) {
                 String url = TemplateUrlService.getInstance().getSearchEngineUrlFromTemplateUrl(
-                        toKeyword(mSelectedSearchEnginePosition));
+                        templateUrl.getKeyword());
                 WebsitePreferenceBridge.nativeSetGeolocationSettingForOrigin(
                         url, url, ContentSetting.DEFAULT.toInt(), false);
             }
             sharedPreferences.edit().remove(PrefServiceBridge.LOCATION_AUTO_ALLOWED).apply();
         }
 
         // Record the change in search engine.
         mSelectedSearchEnginePosition = position;
 
         String keyword = toKeyword(mSelectedSearchEnginePosition);
@@ skipping 12 matching lines @@
     private void onLocationLinkClicked() {
         if (!LocationUtils.getInstance().isSystemLocationSettingEnabled()) {
             mContext.startActivity(LocationUtils.getInstance().getSystemLocationSettingsIntent());
         } else {
             Intent settingsIntent = PreferencesLauncher.createIntentForSettingsPage(
                     mContext, SingleWebsitePreferences.class.getName());
             String url = TemplateUrlService.getInstance().getSearchEngineUrlFromTemplateUrl(
                     toKeyword(mSelectedSearchEnginePosition));
             Bundle fragmentArgs = SingleWebsitePreferences.createFragmentArgsForSite(url);
             fragmentArgs.putBoolean(SingleWebsitePreferences.EXTRA_LOCATION,
-                    locationEnabled(mSelectedSearchEnginePosition, true));
+                    locationEnabled((TemplateUrl) getItem(mSelectedSearchEnginePosition), true));
             settingsIntent.putExtra(Preferences.EXTRA_SHOW_FRAGMENT_ARGUMENTS, fragmentArgs);
             mContext.startActivity(settingsIntent);
         }
     }
 
-    private ContentSetting getLocationPermissionType(int position, boolean checkGeoHeader) {
-        if (position == -1) {
+    private ContentSetting getLocationPermissionType(
+            TemplateUrl templateUrl, boolean checkGeoHeader) {
+        if (templateUrl == null) {
+            assert false;

[Theresa, 2017/01/31 00:35:45]

Do we want to do some logging here (and below) before asserting false?

[Ted C, 2017/01/31 00:54:34]

Done.

             return ContentSetting.BLOCK;
         }
 
         String url = TemplateUrlService.getInstance().getSearchEngineUrlFromTemplateUrl(
-                toKeyword(position));
+                templateUrl.getKeyword());
+        if (url == null) {
+            assert false;
+            return ContentSetting.BLOCK;
+        }
         GeolocationInfo locationSettings = new GeolocationInfo(url, null, false);
         ContentSetting locationPermission = locationSettings.getContentSetting();
         if (locationPermission == ContentSetting.ASK) {
             // Handle the case where the geoHeader being sent when no permission has been specified.
             if (checkGeoHeader) {
                 if (ChromeFeatureList.isEnabled(ChromeFeatureList.CONSISTENT_OMNIBOX_GEOLOCATION)) {
                     if (WebsitePreferenceBridge.shouldUseDSEGeolocationSetting(url, false)) {
                         locationPermission = WebsitePreferenceBridge.getDSEGeolocationSetting()
                                 ? ContentSetting.ALLOW
                                 : ContentSetting.BLOCK;
                     }
                 } else if (GeolocationHeader.isGeoHeaderEnabledForUrl(url, false)) {
                     locationPermission = ContentSetting.ALLOW;
                 }
             }
         }
         return locationPermission;
     }
 
-    private boolean locationEnabled(int position, boolean checkGeoHeader) {
-        return getLocationPermissionType(position, checkGeoHeader) == ContentSetting.ALLOW;
+    private boolean locationEnabled(TemplateUrl templateUrl, boolean checkGeoHeader) {
+        return getLocationPermissionType(templateUrl, checkGeoHeader) == ContentSetting.ALLOW;
     }
 
     private int computeStartIndexForRecentSearchEngines() {
         // If there are custom search engines to show, add 1 for showing the  "Recently visited"
         // header.
         if (mRecentSearchEngines.size() > 0) {
             return mPrepopulatedSearchEngines.size() + 1;
         } else {
             return mPrepopulatedSearchEngines.size();
         }
     }
 }