Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: net/http/http_cache_lookup_manager_unittest.cc

Issue 2668563002: Change MockHttpCache constructor to take boolean to set quic server info factory (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_cache_lookup_manager_unittest.cc
diff --git a/net/http/http_cache_lookup_manager_unittest.cc b/net/http/http_cache_lookup_manager_unittest.cc
index 439aee74a386990afbb66aaf9ff04186392bebb2..d20bdb6c5dcd61a0ab94f8ac8c8fc932b5cebba3 100644
--- a/net/http/http_cache_lookup_manager_unittest.cc
+++ b/net/http/http_cache_lookup_manager_unittest.cc
@@ -83,7 +83,7 @@ void PopulateCacheEntry(HttpCache* cache, const GURL& request_url) {
} // namespace
TEST(HttpCacheLookupManagerTest, ServerPushMissCache) {
- MockHttpCache mock_cache;
+ MockHttpCache mock_cache(false);
Ryan Hamilton 2017/01/31 01:32:26 You might also consider keeping the old no-arg con
Zhongyi Shi 2017/02/02 01:05:12 Done.
HttpCacheLookupManager push_delegate(mock_cache.http_cache(),
NetLogWithSource());
GURL request_url("http://www.example.com/pushed.jpg");
@@ -104,7 +104,7 @@ TEST(HttpCacheLookupManagerTest, ServerPushMissCache) {
}
TEST(HttpCacheLookupManagerTest, ServerPushDoNotCreateCacheEntry) {
- MockHttpCache mock_cache;
+ MockHttpCache mock_cache(false);
HttpCacheLookupManager push_delegate(mock_cache.http_cache(),
NetLogWithSource());
GURL request_url("http://www.example.com/pushed.jpg");
@@ -134,7 +134,7 @@ TEST(HttpCacheLookupManagerTest, ServerPushDoNotCreateCacheEntry) {
}
TEST(HttpCacheLookupManagerTest, ServerPushHitCache) {
- MockHttpCache mock_cache;
+ MockHttpCache mock_cache(false);
HttpCacheLookupManager push_delegate(mock_cache.http_cache(),
NetLogWithSource());
GURL request_url("http://www.example.com/pushed.jpg");
@@ -172,7 +172,7 @@ TEST(HttpCacheLookupManagerTest, ServerPushHitCache) {
// pending lookup transaction for the same URL, the new server push will not
// send a new lookup transaction and should not be canceled.
TEST(HttpCacheLookupManagerTest, ServerPushPendingLookup) {
- MockHttpCache mock_cache;
+ MockHttpCache mock_cache(false);
HttpCacheLookupManager push_delegate(mock_cache.http_cache(),
NetLogWithSource());
GURL request_url("http://www.example.com/pushed.jpg");
@@ -217,7 +217,7 @@ TEST(HttpCacheLookupManagerTest, ServerPushPendingLookup) {
// Test the server push lookup is based on the full url.
TEST(HttpCacheLookupManagerTest, ServerPushLookupOnUrl) {
- MockHttpCache mock_cache;
+ MockHttpCache mock_cache(false);
HttpCacheLookupManager push_delegate(mock_cache.http_cache(),
NetLogWithSource());
GURL request_url("http://www.example.com/pushed.jpg?u=0");

Powered by Google App Engine
This is Rietveld 408576698