Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2668553002: Move resolveRelativeUri into front_end. (Closed)

Created:
3 years, 10 months ago by Paul Berry
Modified:
3 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move resolveRelativeUri into front_end. Note: I removed the exception wrapping code as part of the migration. Rationale: this function performs a small task and has been operating successfully for a long time; removing the exception wrapping code avoids making front_end dependent upon AnalysisException and CaughtException at this time. In the unlikely event that an exception occurs in this function, we still have many avenues available for tracking down the problem: examine the stack trace of the exception, isolate a repeatable test case (if the exception happened in e.g. command-line analyzer), or reproduce the exception from file state information recorded by the AnalysisDriver (if the exception happened in analysis server). R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/d8fc3630cff055376f915422842f3c1bb503cb7f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -33 lines) Patch
M pkg/analyzer/lib/src/generated/utilities_dart.dart View 1 chunk +2 lines, -32 lines 0 comments Download
A pkg/front_end/lib/src/base/resolve_relative_uri.dart View 1 chunk +27 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/incremental_resolved_ast_generator_impl.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 10 months ago (2017-01-30 22:48:39 UTC) #2
scheglov
LGTM
3 years, 10 months ago (2017-01-30 22:57:46 UTC) #3
Paul Berry
3 years, 10 months ago (2017-01-30 23:06:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d8fc3630cff055376f915422842f3c1bb503cb7f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698