Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Unified Diff: pkg/analysis_server/lib/src/domain_analysis.dart

Issue 2668523002: Add missed return leading to an NPE (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/domain_analysis.dart
diff --git a/pkg/analysis_server/lib/src/domain_analysis.dart b/pkg/analysis_server/lib/src/domain_analysis.dart
index 424815d5095ffc6e0a0a38d511f21b8c2c5d7dd0..391f29927ba558d73ca00175b92c48d600d35bb7 100644
--- a/pkg/analysis_server/lib/src/domain_analysis.dart
+++ b/pkg/analysis_server/lib/src/domain_analysis.dart
@@ -173,6 +173,7 @@ class AnalysisDomainHandler implements RequestHandler {
server.onFileAnalysisComplete(file);
if (analysisFuture == null) {
server.sendResponse(new Response.getNavigationInvalidFile(request));
+ return;
}
analysisFuture.then((AnalysisDoneReason reason) async {
switch (reason) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698