Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: tools/testing/dart/runtime_configuration.dart

Issue 2668503003: VM: [Kernel] Switch to DFE for testing -c dartk configuration. (Closed)
Patch Set: Address comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/compiler_configuration.dart ('k') | tools/testing/dart/test_options.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/runtime_configuration.dart
diff --git a/tools/testing/dart/runtime_configuration.dart b/tools/testing/dart/runtime_configuration.dart
index c077e7d9690c7f44aaf9b68717971f9a03ceaa07..d0b90f031a47e409f34b527ceaca7a55df16b1c1 100644
--- a/tools/testing/dart/runtime_configuration.dart
+++ b/tools/testing/dart/runtime_configuration.dart
@@ -227,6 +227,8 @@ class StandaloneDartRuntimeConfiguration extends DartVmRuntimeConfiguration {
CommandArtifact artifact,
List<String> arguments,
Map<String, String> environmentOverrides) {
+ final bool needsDFERunner = suite.configuration['compiler'] == 'dartk' &&
+ !suite.configuration['use-standalone-dartk'];
String script = artifact.filename;
String type = artifact.mimeType;
if (script != null &&
@@ -236,7 +238,7 @@ class StandaloneDartRuntimeConfiguration extends DartVmRuntimeConfiguration {
}
String executable = suite.dartVmBinaryFileName;
return <Command>[
- commandBuilder.getVmCommand(executable, arguments, environmentOverrides)
+ commandBuilder.getVmCommand(executable, arguments, environmentOverrides, needsDFERunner: needsDFERunner)
];
}
}
« no previous file with comments | « tools/testing/dart/compiler_configuration.dart ('k') | tools/testing/dart/test_options.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698