Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2668503002: Remove spurious call to captureStackTrace. (Closed)

Created:
3 years, 10 months ago by Jacob
Modified:
3 years, 10 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove spurious call to captureStackTrace. Just creating an Error object is sufficient on FF, Chrome, Safari, and Edge. Note that captureStackTrace was not supported by other browsers so those browsers were going down the even slower path of throwing an exception. BUG= R=vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/f3c33b047d5dee4d57c867f7a28500c18570c28a

Patch Set 1 #

Patch Set 2 : Optimize StackTrace.current Eliminate redundant call to captureStackTrace and compute the stack tra… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M sdk/lib/_internal/js_runtime/lib/core_patch.dart View 1 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jacob
Remove spurious call to captureStackTrace. Just creating an Error object is sufficient on FF, Chrome, ...
3 years, 10 months ago (2017-01-30 21:28:40 UTC) #2
vsm
lgtm!
3 years, 10 months ago (2017-01-30 21:29:32 UTC) #3
Jacob
3 years, 10 months ago (2017-01-30 21:30:39 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f3c33b047d5dee4d57c867f7a28500c18570c28a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698