Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2668493002: Issue 28547. Fix for summarizing code with invalid type parameter reference. (Closed)

Created:
3 years, 10 months ago by scheglov
Modified:
3 years, 10 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Handle invalid type parameter reference in expressions. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -15 lines) Patch
M pkg/analyzer/lib/src/summary/summarize_ast.dart View 1 6 chunks +16 lines, -15 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_common.dart View 1 2 chunks +19 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 1 2 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
scheglov
3 years, 10 months ago (2017-01-30 20:45:00 UTC) #1
Paul Berry
https://codereview.chromium.org/2668493002/diff/1/pkg/analyzer/lib/src/summary/summarize_ast.dart File pkg/analyzer/lib/src/summary/summarize_ast.dart (right): https://codereview.chromium.org/2668493002/diff/1/pkg/analyzer/lib/src/summary/summarize_ast.dart#newcode110 pkg/analyzer/lib/src/summary/summarize_ast.dart:110: b.reference = Need to add error handling code here ...
3 years, 10 months ago (2017-01-30 20:54:52 UTC) #2
scheglov
PTAL https://codereview.chromium.org/2668493002/diff/1/pkg/analyzer/lib/src/summary/summarize_ast.dart File pkg/analyzer/lib/src/summary/summarize_ast.dart (right): https://codereview.chromium.org/2668493002/diff/1/pkg/analyzer/lib/src/summary/summarize_ast.dart#newcode110 pkg/analyzer/lib/src/summary/summarize_ast.dart:110: b.reference = On 2017/01/30 20:54:52, Paul Berry wrote: ...
3 years, 10 months ago (2017-01-30 21:29:40 UTC) #3
Paul Berry
lgtm, thanks!
3 years, 10 months ago (2017-01-30 21:34:02 UTC) #4
scheglov
3 years, 10 months ago (2017-01-30 21:37:31 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
760347dbae7d69215464185d93ffa4629e6d902d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698