Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 2668473002: Allow SDKs to be analyzed that lack a definition of FutureOr<T>. (Closed)

Created:
3 years, 10 months ago by Paul Berry
Modified:
3 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allow SDKs to be analyzed that lack a definition of FutureOr<T>. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/79b810ebc051b2f9ebb6cc77d22565457398e97d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -19 lines) Patch
M pkg/analyzer/lib/src/generated/resolver.dart View 4 chunks +36 lines, -18 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summary_sdk.dart View 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 10 months ago (2017-01-30 19:25:44 UTC) #2
scheglov
LGTM I hope we can clean this up later.
3 years, 10 months ago (2017-01-30 19:30:47 UTC) #3
Paul Berry
3 years, 10 months ago (2017-01-30 20:19:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
79b810ebc051b2f9ebb6cc77d22565457398e97d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698