Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2668443004: Make the segfault handler attempt to symbolize Dart frames. (Closed)

Created:
3 years, 10 months ago by rmacnak
Modified:
3 years, 10 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make the segfault handler attempt to symbolize Dart frames. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/dfd471eea24cb4307091374515b30633bdbfb62a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -20 lines) Patch
M runtime/bin/platform_linux.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/bin/platform_macos.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/profiler.cc View 3 chunks +14 lines, -20 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
3 years, 10 months ago (2017-01-30 19:06:26 UTC) #2
Florian Schneider
lgtm
3 years, 10 months ago (2017-01-30 20:13:57 UTC) #3
rmacnak
3 years, 10 months ago (2017-01-31 00:39:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dfd471eea24cb4307091374515b30633bdbfb62a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698