Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2668423003: Fix for resynthesizing with multiply defined names. (Closed)

Created:
3 years, 10 months ago by scheglov
Modified:
3 years, 10 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for resynthesizing with multiply defined names. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/dc5258e4cc465aa86dca3ec7567e01ec0342c6a1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -89 lines) Patch
M pkg/analyzer/lib/src/summary/prelink.dart View 18 chunks +152 lines, -88 lines 0 comments Download
M pkg/analyzer/test/src/dart/analysis/driver_test.dart View 1 chunk +10 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_common.dart View 3 chunks +46 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 10 months ago (2017-02-02 04:17:18 UTC) #1
Paul Berry
lgtm
3 years, 10 months ago (2017-02-02 10:56:29 UTC) #2
scheglov
3 years, 10 months ago (2017-02-02 15:11:01 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dc5258e4cc465aa86dca3ec7567e01ec0342c6a1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698