third_party/WebKit/Source/devtools/front_end/network/FilterSuggestionBuilder.js - Issue 2668413003: DevTools: extract NetworkConditionsSelector into its own module

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/FilterSuggestionBuilder.js

Issue 2668413003: DevTools: extract NetworkConditionsSelector into its own module (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/inspector.json ('K') | « third_party/WebKit/Source/devtools/front_end/inspector.json ('k') | third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js » ('j') | third_party/WebKit/Source/devtools/front_end/network_conditions/NetworkConditionsSelector.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/FilterSuggestionBuilder.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/FilterSuggestionBuilder.js b/third_party/WebKit/Source/devtools/front_end/network/FilterSuggestionBuilder.js

index 46ef8573ede99d90b6c907cfa818e2f0e2d0e990..b837594b6b8e66dc339e075e87a0f7df2f2a4c89 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/FilterSuggestionBuilder.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/FilterSuggestionBuilder.js

@@ -89,11 +89,11 @@ Network.FilterSuggestionBuilder = class {

result = [];

/** @type {!Map<number, !Protocol.Network.ResourcePriority>} */

var numericToPriorityMap = new Map();

- Components.prioritySymbolToNumericMap().forEach((value, key) => numericToPriorityMap.set(value, key));

+ NetworkConditions.prioritySymbolToNumericMap().forEach((value, key) => numericToPriorityMap.set(value, key));

var sortedNumericPriorities = numericToPriorityMap.keysArray();

sortedNumericPriorities.sortNumbers();

var sortedPriorities = sortedNumericPriorities.map(value => numericToPriorityMap.get(value));

- var sortedPriorityLabels = sortedPriorities.map(value => Components.uiLabelForPriority(value));

+ var sortedPriorityLabels = sortedPriorities.map(value => NetworkConditions.uiLabelForPriority(value));

for (var value of sortedPriorityLabels) {

if (!resultSet.has(value))