Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Unified Diff: net/nqe/network_quality_estimator.cc

Issue 2668403003: NQE: Do not record correlation if metric is missing (Closed)
Patch Set: ryansturm comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/nqe/network_quality_estimator_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/nqe/network_quality_estimator.cc
diff --git a/net/nqe/network_quality_estimator.cc b/net/nqe/network_quality_estimator.cc
index cf364b5fe13f64a5badffc7d4bc6edd048aed4cd..a52032b085cb3f77976cac3e3412dbc44c705a3b 100644
--- a/net/nqe/network_quality_estimator.cc
+++ b/net/nqe/network_quality_estimator.cc
@@ -626,32 +626,36 @@ void NetworkQualityEstimator::RecordCorrelationMetric(const URLRequest& request,
if (now - last_main_frame_request_ > base::TimeDelta::FromSeconds(15))
return;
+ if (last_connection_change_ >= last_main_frame_request_)
+ return;
+
DCHECK_GE(now, load_timing_info.send_start);
int32_t rtt = 0;
+ if (estimated_quality_at_last_main_frame_.downstream_throughput_kbps() ==
+ nqe::internal::kInvalidThroughput) {
+ return;
+ }
+
if (UseTransportRTT()) {
- rtt = estimated_quality_at_last_main_frame_.transport_rtt() !=
- nqe::internal::InvalidRTT()
- ? FitInKBitsPerMetricBits(
- estimated_quality_at_last_main_frame_.transport_rtt()
- .InMilliseconds())
- : 0;
+ if (estimated_quality_at_last_main_frame_.transport_rtt() ==
+ nqe::internal::InvalidRTT()) {
+ return;
+ }
+ rtt = FitInKBitsPerMetricBits(
+ estimated_quality_at_last_main_frame_.transport_rtt().InMilliseconds());
} else {
- rtt = estimated_quality_at_last_main_frame_.http_rtt() !=
- nqe::internal::InvalidRTT()
- ? FitInKBitsPerMetricBits(
- estimated_quality_at_last_main_frame_.http_rtt()
- .InMilliseconds())
- : 0;
+ if (estimated_quality_at_last_main_frame_.http_rtt() ==
+ nqe::internal::InvalidRTT()) {
+ return;
+ }
+ rtt = FitInKBitsPerMetricBits(
+ estimated_quality_at_last_main_frame_.http_rtt().InMilliseconds());
}
- const int32_t downstream_throughput =
- estimated_quality_at_last_main_frame_.downstream_throughput_kbps() !=
- nqe::internal::kInvalidThroughput
- ? FitInKBitsPerMetricBits(estimated_quality_at_last_main_frame_
- .downstream_throughput_kbps())
- : 0;
+ const int32_t downstream_throughput = FitInKBitsPerMetricBits(
+ estimated_quality_at_last_main_frame_.downstream_throughput_kbps());
const int32_t resource_load_time = FitInKBitsPerMetricBits(
(now - load_timing_info.send_start).InMilliseconds());
« no previous file with comments | « no previous file | net/nqe/network_quality_estimator_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698