[inspector] removed unused code from JavaScriptSourceFrame

src/inspector/wasm-translation.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/inspector/wasm-translation.h"
 
 #include <algorithm>
 
 #include "src/debug/debug-interface.h"
 #include "src/inspector/protocol/Debugger.h"
@@ skipping 18 matching lines @@
                   int column)
         : translation(translation),
           script_id(script_id),
           line(line),
           column(column) {}
   };
 
   virtual void Init(Isolate*, WasmTranslation*, V8DebuggerAgentImpl*) = 0;
   virtual void Translate(TransLocation*) = 0;
   virtual void TranslateBack(TransLocation*) = 0;
+  virtual ~TranslatorImpl() {}
 
   class RawTranslator;
   class DisassemblingTranslator;
 };
 
 class WasmTranslation::TranslatorImpl::RawTranslator
     : public WasmTranslation::TranslatorImpl {
  public:
   void Init(Isolate*, WasmTranslation*, V8DebuggerAgentImpl*) {}
   void Translate(TransLocation*) {}
   void TranslateBack(TransLocation*) {}
 };
 
 class WasmTranslation::TranslatorImpl::DisassemblingTranslator
     : public WasmTranslation::TranslatorImpl {
   using OffsetTable = debug::WasmDisassembly::OffsetTable;
 
  public:
   DisassemblingTranslator(Isolate* isolate, Local<debug::WasmScript> script)
       : script_(isolate, script) {}
 
   void Init(Isolate* isolate, WasmTranslation* translation,
             V8DebuggerAgentImpl* agent) override {
     // Register fake scripts for each function in this wasm module/script.
-    Handle<debug::WasmScript> script = script_.Get(isolate);
+    Local<debug::WasmScript> script = script_.Get(isolate);

[dgozman, 2017/02/02 17:22:18]

How is Handle accessible in this code? Do we include something we should not?

[kozy, 2017/02/02 17:57:34]

I found one suspicious dependency - src/conversions.h for double to string
conversions in string-16.cc. I could try to expose only needed methods via
debug-interface.h in followup.

     int num_functions = script->NumFunctions();
     int num_imported_functions = script->NumImportedFunctions();
     DCHECK_LE(0, num_imported_functions);
     DCHECK_LE(0, num_functions);
     DCHECK_GE(num_functions, num_imported_functions);
     String16 script_id = String16::fromInteger(script->Id());
     for (int func_idx = num_imported_functions; func_idx < num_functions;
          ++func_idx) {
       AddFakeScript(isolate, script_id, func_idx, translation, agent);
     }
@@ skipping 243 matching lines @@
   *column_number = trans_loc.column;
 
   return true;
 }
 
 void WasmTranslation::AddFakeScript(const String16& scriptId,
                                     TranslatorImpl* translator) {
   DCHECK_EQ(0, fake_scripts_.count(scriptId));
   fake_scripts_.insert(std::make_pair(scriptId, translator));
 }