Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 2668353004: Windows: Link library sources into gen_snapshot/dart_bootstrap (Closed)

Created:
3 years, 10 months ago by Florian Schneider
Modified:
3 years, 10 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Windows: Link library sources into gen_snapshot/dart_bootstrap This allows gen_snapshot and dart_bootstrap to run without having a full SDK snapshot around. The generated cc file looks like: static const char source_array_1[] = { '\x2f', '\x2f', '\x20', '\x43', '\x6f', ... }; static const char source_array_2[] = { '\x2f', '\x2f', '\x20', '\x43', '\x6f', ... }; ... const char* dart::Bootstrap::core_source_paths_[] = { "dart:core", "/path/to/sdk/lib/core/core.dart", source_array_1, "annotations.dart", "/path/to/sdk/lib/core/annotations.dart", source_array_2, ... R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/15a4d5d6d190a82204eed48e62627b045db964fe

Patch Set 1 #

Patch Set 2 : don't include non-dart files, make symbols static #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -20 lines) Patch
M runtime/bin/builtin_in.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/lib/libgen_in.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/tools/gen_library_src_paths.py View 1 3 chunks +19 lines, -11 lines 0 comments Download
M runtime/vm/bootstrap.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/globals.h View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Florian Schneider
3 years, 10 months ago (2017-02-01 22:37:03 UTC) #2
Florian Schneider
Hold off - I got a bug to fix...
3 years, 10 months ago (2017-02-01 22:38:49 UTC) #3
Florian Schneider
Ptal.
3 years, 10 months ago (2017-02-01 23:23:42 UTC) #6
siva
lgtm
3 years, 10 months ago (2017-02-01 23:52:33 UTC) #7
Florian Schneider
3 years, 10 months ago (2017-02-01 23:56:06 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
15a4d5d6d190a82204eed48e62627b045db964fe (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698