Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2668253002: Update perf.dart to new API. (Closed)

Created:
3 years, 10 months ago by ahe
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M pkg/compiler/tool/perf.dart View 3 chunks +5 lines, -6 lines 2 comments Download

Depends on Patchset:

Issue 2670443003 Patch 1

Messages

Total messages: 8 (3 generated)
ahe
3 years, 10 months ago (2017-02-01 14:08:34 UTC) #2
karlklose
LGTM
3 years, 10 months ago (2017-02-01 14:25:49 UTC) #4
ahe
Committed patchset #1 (id:1) manually as b6ad994d61083eb142f5d76644f91958040761ca (presubmit successful).
3 years, 10 months ago (2017-02-01 14:39:13 UTC) #6
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2668253002/diff/1/pkg/compiler/tool/perf.dart File pkg/compiler/tool/perf.dart (right): https://codereview.chromium.org/2668253002/diff/1/pkg/compiler/tool/perf.dart#newcode159 pkg/compiler/tool/perf.dart:159: new PartialParser(listener).parseUnit(tokens); fwiw - I think we can ...
3 years, 10 months ago (2017-02-01 15:30:35 UTC) #7
ahe
3 years, 10 months ago (2017-02-01 15:34:06 UTC) #8
Message was sent while issue was closed. 
https://codereview.chromium.org/2668253002/diff/1/pkg/compiler/tool/perf.dart
File pkg/compiler/tool/perf.dart (right):

https://codereview.chromium.org/2668253002/diff/1/pkg/compiler/tool/perf.dart...
pkg/compiler/tool/perf.dart:159: new PartialParser(listener).parseUnit(tokens);
On 2017/02/01 15:30:35, Siggi Cherem (dart-lang) wrote:
> fwiw - I think we can now switch to the top-level parser for this (this is
just
> listening for import/export/part directives)

OK, I'll let you decide what to do.

Powered by Google App Engine
This is Rietveld 408576698