Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1321)

Unified Diff: runtime/vm/raw_object_snapshot.cc

Issue 26682003: Cache number of type arguments in class object instead of recalculating it. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/object.cc ('K') | « runtime/vm/raw_object.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/raw_object_snapshot.cc
===================================================================
--- runtime/vm/raw_object_snapshot.cc (revision 28616)
+++ runtime/vm/raw_object_snapshot.cc (working copy)
@@ -66,7 +66,9 @@
cls.set_next_field_offset_in_words(reader->ReadIntptrValue());
}
cls.set_type_arguments_field_offset_in_words(reader->ReadIntptrValue());
- cls.set_num_native_fields(reader->ReadIntptrValue());
+ cls.set_num_type_arguments(reader->Read<int16_t>());
+ cls.set_num_own_type_arguments(reader->Read<int16_t>());
+ cls.set_num_native_fields(reader->Read<uint16_t>());
cls.set_token_pos(reader->ReadIntptrValue());
cls.set_state_bits(reader->Read<uint16_t>());
@@ -111,7 +113,9 @@
writer->WriteIntptrValue(ptr()->next_field_offset_in_words_);
}
writer->WriteIntptrValue(ptr()->type_arguments_field_offset_in_words_);
- writer->WriteIntptrValue(ptr()->num_native_fields_);
+ writer->Write<int16_t>(ptr()->num_type_arguments_);
+ writer->Write<int16_t>(ptr()->num_own_type_arguments_);
+ writer->Write<uint16_t>(ptr()->num_native_fields_);
writer->WriteIntptrValue(ptr()->token_pos_);
writer->Write<uint16_t>(ptr()->state_bits_);
« runtime/vm/object.cc ('K') | « runtime/vm/raw_object.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698