MD Settings: Fix styles in several places.

chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html

Index: chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
diff --git a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
index db94005f36632647a0c21ad04ea059af11ab05a7..5ae554ff64355dd5482c2d9a4cef85e3a79a0651 100644
--- a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
+++ b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
@@ -126,11 +126,11 @@
     <div class="settings-box block first">
       <h2>$i18n{passwordExceptionsHeading}</h2>
     </div>
-    <div class="list-frame vertical-list">
-      <span id="passwordExceptionsList">
+    <div class="list-frame">
+      <span id="passwordExceptionsList" class="vertical-list">

[dschuyler, 2017/02/01 23:06:23]

May I see a screen shot or demo of what this is changing?

[scottchen, 2017/02/02 01:17:14]

http://imgur.com/a/OOaTg There used to not be borders in between the items

[dschuyler, 2017/02/02 20:02:14]

Thanks.

Please consider merging the attributes from the span on line 130 into the div on
line 129 (and removing the span). Then add
hidden$="[[!hasSome_(passwordExceptions)]]" in that div to be clear that and
line 146 form a mutual exclusion (aka if/else).

[The empty span would work in a similar way, but it's implicit (which is harder
to see/read)].

[scottchen, 2017/02/02 20:31:41]

So I tried that actually, but then realized line 146 is actually inside the div
on line 129, since the "not found" text needs to be displayed as a "list-item"
inside the empty list container, and currently the unit test depends pretty
heavily on counting the number of nodes inside #passwordExceptionList.. 
I'll see what I can do to make this less nested.

         <template is="dom-repeat" items="[[passwordExceptions]]"
             filter="[[passwordExceptionFilter_(filter)]]">
-          <div class="list-item two-line">
+          <div class="list-item">
             <div class="start">
               <a id="exception" href="[[item.linkUrl]]" target="_blank"
                   class="selectable">[[item.exceptionUrl]]</a>