Revert of Move more utility functions to arc_util.

Revert of Move more utility functions to arc_util. (patchset #6 id:140001 of https://codereview.chromium.org/2642783003/ )

Reason for revert:
The new test ChromeArcUtilTest.IsArcAllowedForProfile_SupervisedUserFlow fails on the builder Linux Chromium OS ASan LSan Tests (1).

See example failure: https://luci-milo.appspot.com/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/19296

Original issue's description:
> Move more utility functions to arc_util.
> 
> ArcSessionManager also as static utility methods
> which are not directly related to the class.
> This CL extracts them into arc_util.
> IsArcAllowedForProfile() is still in chrome/browser/chromeos/arc,
> because of its dependency.
> Others are in components/arc/.
> 
> This is preparation to split state machine inside arc_session_manager.
> Also, it's time to add unittest for each.
> 
> BUG=657687
> BUG=b/31079732
> TEST=Ran bots.
> TBR=benwells@chromium.org
> 
> Review-Url: https://codereview.chromium.org/2642783003
> Cr-Commit-Position: refs/heads/master@{#447223}
> Committed: https://chromium.googlesource.com/chromium/src/+/0b75bce63b6fc6a882337f92bb8780ba703efeb8

TBR=lhchavez@chromium.org,yusukes@chromium.org,xiyuan@chromium.org,kinaba@chromium.org,afakhry@chromium.org,skuhne@chromium.org,benwells@chromium.org,nya@chromium.org,khmel@chromium.org,hidehiko@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=657687

[tsergeant, 2017-01-31 23:53:41]

The CQ bit was checked by tsergeant@chromium.org

[tsergeant, 2017-01-31 23:53:42]

Created Revert of Move more utility functions to arc_util.

[Luis Héctor Chávez, 2017-01-31 23:54:16]

lgtm

[commit-bot: I haz the power, 2017-01-31 23:54:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 23:57:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 23:57:19]

Failed to apply patch for chrome/browser/chromeos/arc/arc_session_manager.cc:
While running git apply --index -p1;
  error: patch failed: chrome/browser/chromeos/arc/arc_session_manager.cc:20
  error: chrome/browser/chromeos/arc/arc_session_manager.cc: patch does not
apply

Patch:       chrome/browser/chromeos/arc/arc_session_manager.cc
Index: chrome/browser/chromeos/arc/arc_session_manager.cc
diff --git a/chrome/browser/chromeos/arc/arc_session_manager.cc
b/chrome/browser/chromeos/arc/arc_session_manager.cc
index
dfacaad3af071c51d84bc7e5d63635eded2ca2ec..fdc74180993d965389de64eca4a8f0869cec6be3
100644
--- a/chrome/browser/chromeos/arc/arc_session_manager.cc
+++ b/chrome/browser/chromeos/arc/arc_session_manager.cc
@@ -20,10 +20,12 @@
 #include "chrome/browser/chromeos/arc/arc_auth_notification.h"
 #include "chrome/browser/chromeos/arc/arc_optin_uma.h"
 #include "chrome/browser/chromeos/arc/arc_support_host.h"
-#include "chrome/browser/chromeos/arc/arc_util.h"
 #include "chrome/browser/chromeos/arc/optin/arc_terms_of_service_negotiator.h"
 #include "chrome/browser/chromeos/arc/policy/arc_android_management_checker.h"
 #include "chrome/browser/chromeos/arc/policy/arc_policy_util.h"
+#include "chrome/browser/chromeos/login/user_flow.h"
+#include "chrome/browser/chromeos/login/users/chrome_user_manager.h"
+#include "chrome/browser/chromeos/profiles/profile_helper.h"
 #include "chrome/browser/lifetime/application_lifetime.h"
 #include "chrome/browser/policy/profile_policy_connector.h"
 #include "chrome/browser/policy/profile_policy_connector_factory.h"
@@ -45,6 +47,7 @@
 #include "components/pref_registry/pref_registry_syncable.h"
 #include "components/prefs/pref_service.h"
 #include "components/sync_preferences/pref_service_syncable.h"
+#include "components/user_manager/user.h"
 #include "content/public/browser/browser_thread.h"
 #include "extensions/browser/extension_prefs.h"
 
@@ -64,6 +67,9 @@
 // The Android management check is disabled by default, it's used only for
 // testing.
 bool g_enable_check_android_management_for_testing = false;
+
+// Let IsAllowedForProfile() return "false" for any profile.
+bool g_disallow_for_testing = false;
 
 // Maximum amount of time we'll wait for ARC to finish booting up. Once this
 // timeout expires, keep ARC running in case the user wants to file feedback,
@@ -134,8 +140,81 @@
 }
 
 // static
+bool ArcSessionManager::IsOptInVerificationDisabled() {
+  return base::CommandLine::ForCurrentProcess()->HasSwitch(
+      chromeos::switches::kDisableArcOptInVerification);
+}
+
+// static
 void ArcSessionManager::EnableCheckAndroidManagementForTesting() {
   g_enable_check_android_management_for_testing = true;
+}
+
+// static
+bool ArcSessionManager::IsAllowedForProfile(const Profile* profile) {
+  if (g_disallow_for_testing) {
+    VLOG(1) << "ARC is disallowed for testing.";
+    return false;
+  }
+
+  if (!IsArcAvailable()) {
+    VLOG(1) << "ARC is not available.";
+    return false;
+  }
+
+  if (!profile) {
+    VLOG(1) << "ARC is not supported for systems without profile.";
+    return false;
+  }
+
+  if (!chromeos::ProfileHelper::IsPrimaryProfile(profile)) {
+    VLOG(1) << "Non-primary users are not supported in ARC.";
+    return false;
+  }
+
+  // IsPrimaryProfile can return true for an incognito profile corresponding
+  // to the primary profile, but ARC does not support it.
+  if (profile->IsOffTheRecord()) {
+    VLOG(1) << "Incognito profile is not supported in ARC.";
+    return false;
+  }
+
+  if (profile->IsLegacySupervised()) {
+    VLOG(1) << "Supervised users are not supported in ARC.";
+    return false;
+  }
+
+  user_manager::User const* const user =
+      chromeos::ProfileHelper::Get()->GetUserByProfile(profile);
+  if ((!user || !user->HasGaiaAccount()) && !IsArcKioskMode()) {
+    VLOG(1) << "Users without GAIA accounts are not supported in ARC.";
+    return false;
+  }
+
+  chromeos::UserFlow* user_flow =
+      chromeos::ChromeUserManager::Get()->GetUserFlow(user->GetAccountId());
+  if (!user_flow || !user_flow->CanStartArc()) {
+    VLOG(1) << "ARC is not allowed in the current user flow.";
+    return false;
+  }
+
+  if (user_manager::UserManager::Get()
+          ->IsCurrentUserCryptohomeDataEphemeral()) {
+    VLOG(2) << "Users with ephemeral data are not supported in ARC.";
+    return false;
+  }
+
+  return true;
+}
+
+// static
+void ArcSessionManager::DisallowForTesting() {
+  g_disallow_for_testing = true;
+}
+
+// static
+bool ArcSessionManager::IsArcKioskMode() {
+  return user_manager::UserManager::Get()->IsLoggedInAsArcKioskApp();
 }
 
 void ArcSessionManager::OnSessionReady() {
@@ -286,7 +365,7 @@
     profile_->GetPrefs()->SetBoolean(prefs::kArcSignedIn, true);
     // Don't show Play Store app for ARC Kiosk because the only one UI in kiosk
     // mode must be the kiosk app and device is not needed for opt-in.
-    if (!IsArcOptInVerificationDisabled() && !IsArcKioskMode()) {
+    if (!IsOptInVerificationDisabled() && !IsArcKioskMode()) {
       playstore_launcher_.reset(
           new ArcAppLauncher(profile_, kPlayStoreAppId, true));
     }
@@ -370,10 +449,10 @@
 
   Shutdown();
 
-  if (!IsArcAllowedForProfile(profile))
-    return;
-
-  // TODO(khmel): Move this to IsArcAllowedForProfile.
+  if (!IsAllowedForProfile(profile))
+    return;
+
+  // TODO(khmel): Move this to IsAllowedForProfile.
   if (policy_util::IsArcDisabledForEnterprise() &&
       policy_util::IsAccountManaged(profile)) {
     VLOG(2) << "Enterprise users are not supported in ARC.";
@@ -391,7 +470,7 @@
   // be the kiosk app. In case of error the UI will be useless as well, because
   // in typical use case there will be no one nearby the kiosk device, who can
   // do some action to solve the problem be means of UI.
-  if (!g_disable_ui_for_testing && !IsArcOptInVerificationDisabled() &&
+  if (!g_disable_ui_for_testing && !IsOptInVerificationDisabled() &&
       !IsArcKioskMode()) {
     DCHECK(!support_host_);
     support_host_ = base::MakeUnique<ArcSupportHost>(profile_);
@@ -553,13 +632,13 @@
   // For backward compatibility, this check needs to be prior to the
   // kArcTermsAccepted check below.
   if (profile_->GetPrefs()->GetBoolean(prefs::kArcSignedIn) ||
-      IsArcOptInVerificationDisabled() || IsArcKioskMode()) {
+      IsOptInVerificationDisabled() || IsArcKioskMode()) {
     StartArc();
 
     // Skip Android management check for testing.
     // We also skip if Android management check for Kiosk mode,
     // because there are no managed human users for Kiosk exist.
-    if (IsArcOptInVerificationDisabled() || IsArcKioskMode() ||
+    if (IsOptInVerificationDisabled() || IsArcKioskMode() ||
         (g_disable_ui_for_testing &&
          !g_enable_check_android_management_for_testing)) {
       return;

[khmel, 2017-01-31 23:58:32]

On 2017/01/31 23:57:19, commit-bot: I haz the power wrote:
> Failed to apply patch for chrome/browser/chromeos/arc/arc_session_manager.cc:
> While running git apply --index -p1;
>   error: patch failed: chrome/browser/chromeos/arc/arc_session_manager.cc:20
>   error: chrome/browser/chromeos/arc/arc_session_manager.cc: patch does not
> apply
> 
> Patch:       chrome/browser/chromeos/arc/arc_session_manager.cc
> Index: chrome/browser/chromeos/arc/arc_session_manager.cc
> diff --git a/chrome/browser/chromeos/arc/arc_session_manager.cc
> b/chrome/browser/chromeos/arc/arc_session_manager.cc
> index
>
dfacaad3af071c51d84bc7e5d63635eded2ca2ec..fdc74180993d965389de64eca4a8f0869cec6be3
> 100644
> --- a/chrome/browser/chromeos/arc/arc_session_manager.cc
> +++ b/chrome/browser/chromeos/arc/arc_session_manager.cc
> @@ -20,10 +20,12 @@
>  #include "chrome/browser/chromeos/arc/arc_auth_notification.h"
>  #include "chrome/browser/chromeos/arc/arc_optin_uma.h"
>  #include "chrome/browser/chromeos/arc/arc_support_host.h"
> -#include "chrome/browser/chromeos/arc/arc_util.h"
>  #include
"chrome/browser/chromeos/arc/optin/arc_terms_of_service_negotiator.h"
>  #include
"chrome/browser/chromeos/arc/policy/arc_android_management_checker.h"
>  #include "chrome/browser/chromeos/arc/policy/arc_policy_util.h"
> +#include "chrome/browser/chromeos/login/user_flow.h"
> +#include "chrome/browser/chromeos/login/users/chrome_user_manager.h"
> +#include "chrome/browser/chromeos/profiles/profile_helper.h"
>  #include "chrome/browser/lifetime/application_lifetime.h"
>  #include "chrome/browser/policy/profile_policy_connector.h"
>  #include "chrome/browser/policy/profile_policy_connector_factory.h"
> @@ -45,6 +47,7 @@
>  #include "components/pref_registry/pref_registry_syncable.h"
>  #include "components/prefs/pref_service.h"
>  #include "components/sync_preferences/pref_service_syncable.h"
> +#include "components/user_manager/user.h"
>  #include "content/public/browser/browser_thread.h"
>  #include "extensions/browser/extension_prefs.h"
>  
> @@ -64,6 +67,9 @@
>  // The Android management check is disabled by default, it's used only for
>  // testing.
>  bool g_enable_check_android_management_for_testing = false;
> +
> +// Let IsAllowedForProfile() return "false" for any profile.
> +bool g_disallow_for_testing = false;
>  
>  // Maximum amount of time we'll wait for ARC to finish booting up. Once this
>  // timeout expires, keep ARC running in case the user wants to file feedback,
> @@ -134,8 +140,81 @@
>  }
>  
>  // static
> +bool ArcSessionManager::IsOptInVerificationDisabled() {
> +  return base::CommandLine::ForCurrentProcess()->HasSwitch(
> +      chromeos::switches::kDisableArcOptInVerification);
> +}
> +
> +// static
>  void ArcSessionManager::EnableCheckAndroidManagementForTesting() {
>    g_enable_check_android_management_for_testing = true;
> +}
> +
> +// static
> +bool ArcSessionManager::IsAllowedForProfile(const Profile* profile) {
> +  if (g_disallow_for_testing) {
> +    VLOG(1) << "ARC is disallowed for testing.";
> +    return false;
> +  }
> +
> +  if (!IsArcAvailable()) {
> +    VLOG(1) << "ARC is not available.";
> +    return false;
> +  }
> +
> +  if (!profile) {
> +    VLOG(1) << "ARC is not supported for systems without profile.";
> +    return false;
> +  }
> +
> +  if (!chromeos::ProfileHelper::IsPrimaryProfile(profile)) {
> +    VLOG(1) << "Non-primary users are not supported in ARC.";
> +    return false;
> +  }
> +
> +  // IsPrimaryProfile can return true for an incognito profile corresponding
> +  // to the primary profile, but ARC does not support it.
> +  if (profile->IsOffTheRecord()) {
> +    VLOG(1) << "Incognito profile is not supported in ARC.";
> +    return false;
> +  }
> +
> +  if (profile->IsLegacySupervised()) {
> +    VLOG(1) << "Supervised users are not supported in ARC.";
> +    return false;
> +  }
> +
> +  user_manager::User const* const user =
> +      chromeos::ProfileHelper::Get()->GetUserByProfile(profile);
> +  if ((!user || !user->HasGaiaAccount()) && !IsArcKioskMode()) {
> +    VLOG(1) << "Users without GAIA accounts are not supported in ARC.";
> +    return false;
> +  }
> +
> +  chromeos::UserFlow* user_flow =
> +      chromeos::ChromeUserManager::Get()->GetUserFlow(user->GetAccountId());
> +  if (!user_flow || !user_flow->CanStartArc()) {
> +    VLOG(1) << "ARC is not allowed in the current user flow.";
> +    return false;
> +  }
> +
> +  if (user_manager::UserManager::Get()
> +          ->IsCurrentUserCryptohomeDataEphemeral()) {
> +    VLOG(2) << "Users with ephemeral data are not supported in ARC.";
> +    return false;
> +  }
> +
> +  return true;
> +}
> +
> +// static
> +void ArcSessionManager::DisallowForTesting() {
> +  g_disallow_for_testing = true;
> +}
> +
> +// static
> +bool ArcSessionManager::IsArcKioskMode() {
> +  return user_manager::UserManager::Get()->IsLoggedInAsArcKioskApp();
>  }
>  
>  void ArcSessionManager::OnSessionReady() {
> @@ -286,7 +365,7 @@
>      profile_->GetPrefs()->SetBoolean(prefs::kArcSignedIn, true);
>      // Don't show Play Store app for ARC Kiosk because the only one UI in
kiosk
>      // mode must be the kiosk app and device is not needed for opt-in.
> -    if (!IsArcOptInVerificationDisabled() && !IsArcKioskMode()) {
> +    if (!IsOptInVerificationDisabled() && !IsArcKioskMode()) {
>        playstore_launcher_.reset(
>            new ArcAppLauncher(profile_, kPlayStoreAppId, true));
>      }
> @@ -370,10 +449,10 @@
>  
>    Shutdown();
>  
> -  if (!IsArcAllowedForProfile(profile))
> -    return;
> -
> -  // TODO(khmel): Move this to IsArcAllowedForProfile.
> +  if (!IsAllowedForProfile(profile))
> +    return;
> +
> +  // TODO(khmel): Move this to IsAllowedForProfile.
>    if (policy_util::IsArcDisabledForEnterprise() &&
>        policy_util::IsAccountManaged(profile)) {
>      VLOG(2) << "Enterprise users are not supported in ARC.";
> @@ -391,7 +470,7 @@
>    // be the kiosk app. In case of error the UI will be useless as well,
because
>    // in typical use case there will be no one nearby the kiosk device, who
can
>    // do some action to solve the problem be means of UI.
> -  if (!g_disable_ui_for_testing && !IsArcOptInVerificationDisabled() &&
> +  if (!g_disable_ui_for_testing && !IsOptInVerificationDisabled() &&
>        !IsArcKioskMode()) {
>      DCHECK(!support_host_);
>      support_host_ = base::MakeUnique<ArcSupportHost>(profile_);
> @@ -553,13 +632,13 @@
>    // For backward compatibility, this check needs to be prior to the
>    // kArcTermsAccepted check below.
>    if (profile_->GetPrefs()->GetBoolean(prefs::kArcSignedIn) ||
> -      IsArcOptInVerificationDisabled() || IsArcKioskMode()) {
> +      IsOptInVerificationDisabled() || IsArcKioskMode()) {
>      StartArc();
>  
>      // Skip Android management check for testing.
>      // We also skip if Android management check for Kiosk mode,
>      // because there are no managed human users for Kiosk exist.
> -    if (IsArcOptInVerificationDisabled() || IsArcKioskMode() ||
> +    if (IsOptInVerificationDisabled() || IsArcKioskMode() ||
>          (g_disable_ui_for_testing &&
>           !g_enable_check_android_management_for_testing)) {
>        return;

CL https://codereview.chromium.org/2561023002/ was landed over this,

[khmel, 2017-02-01 00:00:00]

Probably we may just add   GetFakeUserManager()->ResetUserFlow(manager_id); to
the failing test.