Change hover element to scrollbar's parent when hit test contains scrollbar

third_party/WebKit/Source/core/dom/Document.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All
  * rights reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved.
  * (http://www.torchmobile.com/)
  * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
@@ skipping 6070 matching lines @@
   }
 
   return 0;
 }
 
 void Document::updateHoverActiveState(const HitTestRequest& request,
                                       Element* innerElement,
                                       Scrollbar* hitScrollbar) {
   DCHECK(!request.readOnly());
 
-  // Only cancel hover state when hitting native scrollbar because custom
-  // scrollbar's style depends on the owner element's hover state.
-  bool hitNativeScrollbar = hitScrollbar && !hitScrollbar->isCustomScrollbar();
-
-  if (request.active() && m_frame && !hitNativeScrollbar)
+  if (request.active() && m_frame)
     m_frame->eventHandler().notifyElementActivated();
 
-  Element* innerElementInDocument = hitNativeScrollbar ? nullptr : innerElement;
+  Element* innerElementInDocument = hitScrollbar ? nullptr : innerElement;
+  // Replace the innerElementInDocument to be srollbar's parent when hit
+  // scrollbar
+  if (hitScrollbar) {
+    ScrollableArea* scrollableArea = hitScrollbar->getScrollableArea();
+    if (scrollableArea && scrollableArea->layoutBox() &&
+        scrollableArea->layoutBox()->node() &&
+        scrollableArea->layoutBox()->node()->isElementNode()) {
+      innerElementInDocument =

[bokan, 2017/02/02 23:29:26]

You've confirmed that this preserves the hover effect for custom scrollbars?

[chaopeng, 2017/02/03 01:12:05]

Yes, the customer scrollbar issue is also cause by scrollbar depends on it's
parent's hover state.

+          toElement(hitScrollbar->getScrollableArea()->layoutBox()->node());
+    }
+  }
+
   while (innerElementInDocument && innerElementInDocument->document() != this) {
     innerElementInDocument->document().updateHoverActiveState(
         request, innerElementInDocument, hitScrollbar);
     innerElementInDocument = innerElementInDocument->document().localOwner();
   }
 
   updateDistribution();
   Element* oldActiveElement = activeHoverElement();
-  if (oldActiveElement && (!request.active() || hitNativeScrollbar)) {
+  if (oldActiveElement && !request.active()) {
     // The oldActiveElement layoutObject is null, dropped on :active by setting
     // display: none, for instance. We still need to clear the ActiveChain as
     // the mouse is released.
     for (Node* node = oldActiveElement; node;
          node = FlatTreeTraversal::parent(*node)) {
       DCHECK(!node->isTextNode());
       node->setActive(false);
       m_userActionElements.setInActiveChain(node, false);
     }
     setActiveHoverElement(nullptr);
@@ skipping 451 matching lines @@
 }
 
 void showLiveDocumentInstances() {
   WeakDocumentSet& set = liveDocumentSet();
   fprintf(stderr, "There are %u documents currently alive:\n", set.size());
   for (blink::Document* document : set)
     fprintf(stderr, "- Document %p URL: %s\n", document,
             document->url().getString().utf8().data());
 }
 #endif