step: expose get_context() to get the context object

recipe_modules/step/api.py

 # Copyright 2013 The LUCI Authors. All rights reserved.
 # Use of this source code is governed under the Apache License, Version 2.0
 # that can be found in the LICENSE file.
 
 import contextlib
 import datetime
 
 from recipe_engine import recipe_api
 
 
@@ skipping 59 matching lines @@
           new_step_text = result.json.output['step_text']
           api.step.active_result.presentation.step_text = new_step_text
     """
     return self.step_client.previous_step_result()
 
   @property
   def context(self):
     """ See recipe_api.py for docs. """
     return recipe_api.context
 
+  def get_context(self):
+    return recipe_api._STEP_CONTEXT

[iannucci, 2017/01/31 22:12:51]

this should return a copy of the step context (unless _STEP_CONTEXT is
immutable? I forget).

needs docstring

[iannucci, 2017/01/31 22:14:49]

This is also confusing with the previous property. Maybe current_context?

+
   @contextlib.contextmanager
   def nest(self, name):
     """Nest is the high-level interface to annotated hierarchical steps.
 
     Calling
 
         with api.step.nest(<name>):
           ...
 
     will generate a dummy step and implicitly create a new context (as
@@ skipping 75 matching lines @@
 
     if cmd is not None:
       command = list(wrapper)
       command += cmd
       kwargs['cmd'] = command
 
     kwargs['timeout'] = timeout
     kwargs['ok_ret'] = ok_ret
 
     # Obtain information from composite step parent.
-    compositor = recipe_api._STEP_CONTEXT
+    compositor = self.get_context()
 
     # Calculate our full step name. If a step already has that name, add an
     # index to the end of it.
     #
     # Note that another step could exist with that index already added to it
     # by the user. If this happens, we'll continue appending indexes until we
     # have a unique step name.
     while True:
       full_name = compositor.get_with_context('name', name)
       if full_name not in self._seen_steps:
@@ skipping 14 matching lines @@
     kwargs['base_name'] = name
 
     schema = self.make_config()
     schema.set_val(kwargs)
     return self.run_from_dict(schema.as_jsonish())
 
   # TODO(martiniss) delete, and make generator_script use **kwargs on step()
   @recipe_api.composite_step
   def run_from_dict(self, dct):
     return self.step_client.run_step(dct)