Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Side by Side Diff: build/config/sanitizers/sanitizers.gni

Issue 2668093004: Revert of Use trace-pc-guard for libFuzzer. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/chrome_build.gni") 5 import("//build/config/chrome_build.gni")
6 import("//build/toolchain/toolchain.gni") 6 import("//build/toolchain/toolchain.gni")
7 7
8 declare_args() { 8 declare_args() {
9 # Compile for Address Sanitizer to find memory bugs. 9 # Compile for Address Sanitizer to find memory bugs.
10 is_asan = false 10 is_asan = false
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
132 # Enable -fsanitize-coverage. 132 # Enable -fsanitize-coverage.
133 use_sanitizer_coverage = 133 use_sanitizer_coverage =
134 use_libfuzzer || use_afl || sanitizer_coverage_flags != "" 134 use_libfuzzer || use_afl || sanitizer_coverage_flags != ""
135 135
136 # Detect overflow/underflow for global objects. 136 # Detect overflow/underflow for global objects.
137 # 137 #
138 # Mac: http://crbug.com/352073 138 # Mac: http://crbug.com/352073
139 asan_globals = !is_mac 139 asan_globals = !is_mac
140 } 140 }
141 141
142 if ((use_afl || use_libfuzzer) && sanitizer_coverage_flags == "") { 142 if (use_afl && sanitizer_coverage_flags == "") {
143 sanitizer_coverage_flags = "trace-pc-guard" 143 sanitizer_coverage_flags = "trace-pc-guard"
144 } else if (use_sanitizer_coverage && sanitizer_coverage_flags == "") { 144 } else if (use_sanitizer_coverage && sanitizer_coverage_flags == "") {
145 sanitizer_coverage_flags = "edge,indirect-calls,8bit-counters" 145 sanitizer_coverage_flags = "edge,indirect-calls,8bit-counters"
146 } 146 }
147 147
148 using_sanitizer = 148 using_sanitizer =
149 is_asan || is_lsan || is_tsan || is_msan || is_ubsan || is_ubsan_null || 149 is_asan || is_lsan || is_tsan || is_msan || is_ubsan || is_ubsan_null ||
150 is_ubsan_vptr || is_ubsan_security || use_sanitizer_coverage 150 is_ubsan_vptr || is_ubsan_security || use_sanitizer_coverage
151 151
152 assert(!using_sanitizer || is_clang, 152 assert(!using_sanitizer || is_clang,
(...skipping 24 matching lines...) Expand all
177 # this condition. We may also be able to find another way to enable your case 177 # this condition. We may also be able to find another way to enable your case
178 # without having people accidentally get broken builds by compiling an 178 # without having people accidentally get broken builds by compiling an
179 # unsupported or unadvisable configurations. 179 # unsupported or unadvisable configurations.
180 # 180 #
181 # For one-off testing, just comment this assertion out. 181 # For one-off testing, just comment this assertion out.
182 assert(!is_debug || !(is_msan || is_ubsan || is_ubsan_null || is_ubsan_vptr), 182 assert(!is_debug || !(is_msan || is_ubsan || is_ubsan_null || is_ubsan_vptr),
183 "Sanitizers should generally be used in release (set is_debug=false).") 183 "Sanitizers should generally be used in release (set is_debug=false).")
184 184
185 assert(!is_msan || (is_linux && current_cpu == "x64"), 185 assert(!is_msan || (is_linux && current_cpu == "x64"),
186 "MSan currently only works on 64-bit Linux and ChromeOS builds.") 186 "MSan currently only works on 64-bit Linux and ChromeOS builds.")
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698