Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/core/css/CSSProperties.json5

Issue 2668093003: Revert of Added api_methods flag to CSSProperties.json5. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/build/scripts/templates/CSSPropertyAPIFiles.h.tmpl ('k') | third_party/WebKit/Source/core/css/properties/CSSPropertyAPI.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/CSSProperties.json5
diff --git a/third_party/WebKit/Source/core/css/CSSProperties.json5 b/third_party/WebKit/Source/core/css/CSSProperties.json5
index 712641bc646edaaea24e0113e9237bde5234ddaa..562ef429b0c9cbd0bfa9ca57ca638c2c04ba54da 100644
--- a/third_party/WebKit/Source/core/css/CSSProperties.json5
+++ b/third_party/WebKit/Source/core/css/CSSProperties.json5
@@ -31,7 +31,7 @@
// - api_class: true|"classname"
// Specifies the existance (and optionally name) of a CSSPropertyAPI
- // implementation for the property to be used by make_css_property_apis.py.
+ // implementation for the property to be used by make_css_property_descriptor.py.
// See core/css/properties/CSSPropertyAPI.h for API details.
// * Add this flag if the API has been implemented for this property.
// * If the classname for this is different to the name of the property, specify a
@@ -40,17 +40,6 @@
// properties with default classnames do not get this flag, and introduce a
// 'not_implemented' flag instead.
api_class: {
- },
-
- // - api_methods: ["method1", "method2"]
- // List of methods that are implemented in the CSSPropertyAPI for this property.
- // This is used by make_css_property_apis.py to specify which functions are defined
- // in the .h file for this property, and also used in CSSPropertyAPIFiles.h.tmpl to
- // generate declarations for only the methods this property has implementations for.
- api_methods: {
- default: [],
- valid_type: "list",
- valid_values: ["parseSingleValue"],
},
// - keyword_only
@@ -363,7 +352,6 @@
{
name: "font-size-adjust",
api_class: true,
- api_methods: ["parseSingleValue"],
converter: "convertFontSizeAdjust",
font: true,
inherited: true,
@@ -391,7 +379,6 @@
{
name: "font-variant-ligatures",
api_class: true,
- api_methods: ["parseSingleValue"],
converter: "convertFontVariantLigatures",
font: true,
inherited: true,
@@ -402,7 +389,6 @@
{
name: "font-variant-caps",
api_class: true,
- api_methods: ["parseSingleValue"],
converter: "convertFontVariantCaps",
font: true,
inherited: true,
@@ -412,7 +398,6 @@
{
name: "font-variant-numeric",
api_class: true,
- api_methods: ["parseSingleValue"],
converter: "convertFontVariantNumeric",
font: true,
inherited: true,
@@ -440,7 +425,6 @@
{
name: "font-variation-settings",
api_class: true,
- api_methods: ["parseSingleValue"],
converter: "convertFontVariationSettings",
font: true,
inherited: true,
@@ -504,7 +488,6 @@
{
name: "zoom",
api_class: true,
- api_methods: ["parseSingleValue"],
custom_all: true,
priority: "High",
},
@@ -516,21 +499,19 @@
},
{
name: "align-items",
- api_class: true,
- api_methods: ["parseSingleValue"],
converter: "convertSelfOrDefaultAlignmentData",
initial: "initialDefaultAlignment",
+ api_class: true,
},
{
name: "alignment-baseline",
svg: true,
},
{
- api_class: "CSSPropertyAPIAlignOrJustifySelf",
- api_methods: ["parseSingleValue"],
name: "align-self",
converter: "convertSelfOrDefaultAlignmentData",
initial: "initialSelfAlignment",
+ api_class: "CSSPropertyAPIAlignOrJustifySelf",
},
{
name: "backdrop-filter",
@@ -593,7 +574,6 @@
{
name: "baseline-shift",
api_class: true,
- api_methods: ["parseSingleValue"],
custom_inherit: true,
custom_value: true,
interpolable: true,
@@ -607,7 +587,6 @@
{
name: "border-bottom-left-radius",
api_class: "CSSPropertyAPIBorderRadius",
- api_methods: ["parseSingleValue"],
converter: "convertRadius",
initial: "initialBorderRadius",
interpolable: true,
@@ -615,7 +594,6 @@
{
name: "border-bottom-right-radius",
api_class: "CSSPropertyAPIBorderRadius",
- api_methods: ["parseSingleValue"],
converter: "convertRadius",
initial: "initialBorderRadius",
interpolable: true,
@@ -656,7 +634,6 @@
{
name: "border-image-source",
api_class: "CSSPropertyAPIImage",
- api_methods: ["parseSingleValue"],
custom_value: true,
interpolable: true,
keywords: ["none"],
@@ -707,7 +684,6 @@
{
name: "border-top-left-radius",
api_class: "CSSPropertyAPIBorderRadius",
- api_methods: ["parseSingleValue"],
converter: "convertRadius",
initial: "initialBorderRadius",
interpolable: true,
@@ -715,7 +691,6 @@
{
name: "border-top-right-radius",
api_class: "CSSPropertyAPIBorderRadius",
- api_methods: ["parseSingleValue"],
converter: "convertRadius",
initial: "initialBorderRadius",
interpolable: true,
@@ -776,7 +751,6 @@
{
name: "caret-color",
api_class: true,
- api_methods: ["parseSingleValue"],
custom_all: true,
inherited: true,
interpolable: true,
@@ -790,7 +764,6 @@
{
name: "clip",
api_class: true,
- api_methods: ["parseSingleValue"],
converter: "convertClip",
custom_all: true,
interpolable: true,
@@ -798,7 +771,6 @@
{
name: "clip-path",
api_class: true,
- api_methods: ["parseSingleValue"],
converter: "convertClipPath",
interpolable: true,
},
@@ -831,14 +803,12 @@
{
name: "contain",
api_class: true,
- api_methods: ["parseSingleValue"],
converter: "convertFlags<Containment>",
runtime_flag: "CSSContainment",
},
{
name: "content",
api_class: true,
- api_methods: ["parseSingleValue"],
custom_all: true,
repeated: true,
typedom_types: ["Image"],
@@ -854,7 +824,6 @@
{
name: "cursor",
api_class: true,
- api_methods: ["parseSingleValue"],
custom_all: true,
inherited: true,
},
@@ -894,7 +863,6 @@
{
name: "fill",
api_class: "CSSPropertyAPIPaintStroke",
- api_methods: ["parseSingleValue"],
custom_all: true,
inherited: true,
interpolable: true,
@@ -904,7 +872,6 @@
{
name: "fill-opacity",
api_class: "CSSPropertyAPIOpacity",
- api_methods: ["parseSingleValue"],
converter: "convertNumberOrPercentage",
inherited: true,
interpolable: true,
@@ -924,7 +891,6 @@
{
name: "flex-basis",
api_class: true,
- api_methods: ["parseSingleValue"],
converter: "convertLengthOrAuto",
interpolable: true,
},
@@ -951,7 +917,6 @@
{
name: "flood-color",
api_class: "CSSPropertyAPIColor",
- api_methods: ["parseSingleValue"],
converter: "convertColor",
interpolable: true,
svg: true,
@@ -959,7 +924,6 @@
{
name: "flood-opacity",
api_class: "CSSPropertyAPIOpacity",
- api_methods: ["parseSingleValue"],
converter: "convertNumberOrPercentage",
interpolable: true,
svg: true,
@@ -972,7 +936,6 @@
{
name: "grid-auto-flow",
api_class: true,
- api_methods: ["parseSingleValue"],
converter: "convertGridAutoFlow",
runtime_flag: "CSSGridLayout",
type_name: "GridAutoFlow",
@@ -1049,7 +1012,6 @@
{
name: "image-orientation",
api_class: true,
- api_methods: ["parseSingleValue"],
converter: "convertImageOrientation",
inherited: true,
name_for_methods: "RespectImageOrientation",
@@ -1063,19 +1025,17 @@
},
{
name: "justify-items",
- api_class: true,
- api_methods: ["parseSingleValue"],
converter: "convertSelfOrDefaultAlignmentData",
initial: "initialSelfAlignment",
runtime_flag: "CSSGridLayout",
+ api_class: true,
},
{
name: "justify-self",
- api_class: "CSSPropertyAPIAlignOrJustifySelf",
- api_methods: ["parseSingleValue"],
converter: "convertSelfOrDefaultAlignmentData",
initial: "initialSelfAlignment",
runtime_flag: "CSSGridLayout",
+ api_class: "CSSPropertyAPIAlignOrJustifySelf",
},
{
name: "left",
@@ -1089,7 +1049,6 @@
{
name: "letter-spacing",
api_class: "CSSPropertyAPILetterAndWordSpacing",
- api_methods: ["parseSingleValue"],
converter: "convertSpacing",
inherited: true,
initial: "initialLetterWordSpacing",
@@ -1098,7 +1057,6 @@
{
name: "lighting-color",
api_class: "CSSPropertyAPIColor",
- api_methods: ["parseSingleValue"],
converter: "convertColor",
interpolable: true,
svg: true,
@@ -1113,7 +1071,6 @@
{
name: "list-style-image",
api_class: "CSSPropertyAPIImage",
- api_methods: ["parseSingleValue"],
custom_value: true,
inherited: true,
interpolable: true,
@@ -1264,7 +1221,6 @@
{
name: "offset-position",
api_class: true,
- api_methods: ["parseSingleValue"],
converter: "convertPositionOrAuto",
interpolable: true,
runtime_flag: "CSSOffsetPositionAnchor",
@@ -1284,14 +1240,12 @@
{
name: "opacity",
api_class: "CSSPropertyAPIOpacity",
- api_methods: ["parseSingleValue"],
interpolable: true,
type_name: "float",
},
{
name: "order",
api_class: true,
- api_methods: ["parseSingleValue"],
type_name: "int",
},
{
@@ -1303,14 +1257,12 @@
{
name: "outline-color",
api_class: true,
- api_methods: ["parseSingleValue"],
custom_all: true,
interpolable: true,
},
{
name: "outline-offset",
api_class: true,
- api_methods: ["parseSingleValue"],
converter: "convertComputedLength<int>",
interpolable: true,
},
@@ -1321,7 +1273,6 @@
{
name: "outline-width",
api_class: true,
- api_methods: ["parseSingleValue"],
converter: "convertLineWidth<unsigned short>",
interpolable: true,
},
@@ -1345,7 +1296,6 @@
{
name: "padding-bottom",
api_class: "CSSPropertyAPIPadding",
- api_methods: ["parseSingleValue"],
converter: "convertLength",
initial: "initialPadding",
interpolable: true,
@@ -1353,7 +1303,6 @@
{
name: "padding-left",
api_class: "CSSPropertyAPIPadding",
- api_methods: ["parseSingleValue"],
converter: "convertLength",
initial: "initialPadding",
interpolable: true,
@@ -1361,7 +1310,6 @@
{
name: "padding-right",
api_class: "CSSPropertyAPIPadding",
- api_methods: ["parseSingleValue"],
converter: "convertLength",
initial: "initialPadding",
interpolable: true,
@@ -1369,7 +1317,6 @@
{
name: "padding-top",
api_class: "CSSPropertyAPIPadding",
- api_methods: ["parseSingleValue"],
converter: "convertLength",
initial: "initialPadding",
interpolable: true,
@@ -1377,7 +1324,6 @@
{
name: "paint-order",
api_class: true,
- api_methods: ["parseSingleValue"],
converter: "convertPaintOrder",
inherited: true,
svg: true,
@@ -1409,7 +1355,6 @@
{
name: "quotes",
api_class: true,
- api_methods: ["parseSingleValue"],
converter: "convertQuotes",
inherited: true,
},
@@ -1435,7 +1380,6 @@
{
name: "rx",
api_class: "CSSPropertyAPIRadius",
- api_methods: ["parseSingleValue"],
converter: "convertLengthOrAuto",
interpolable: true,
svg: true,
@@ -1443,7 +1387,6 @@
{
name: "ry",
api_class: "CSSPropertyAPIRadius",
- api_methods: ["parseSingleValue"],
converter: "convertLengthOrAuto",
interpolable: true,
svg: true,
@@ -1476,28 +1419,24 @@
{
name: "scroll-snap-coordinate",
api_class: true,
- api_methods: ["parseSingleValue"],
converter: "convertSnapCoordinates",
runtime_flag: "CSSScrollSnapPoints",
},
{
name: "shape-image-threshold",
api_class: true,
- api_methods: ["parseSingleValue"],
interpolable: true,
type_name: "float",
},
{
name: "shape-margin",
api_class: true,
- api_methods: ["parseSingleValue"],
converter: "convertLength",
interpolable: true,
},
{
name: "shape-outside",
api_class: true,
- api_methods: ["parseSingleValue"],
converter: "convertShapeValue",
interpolable: true,
typedom_types: ["Image"],
@@ -1510,13 +1449,11 @@
{
name: "size",
api_class: true,
- api_methods: ["parseSingleValue"],
custom_all: true,
},
{
name: "snap-height",
api_class: true,
- api_methods: ["parseSingleValue"],
custom_all: true,
inherited: true,
runtime_flag: "CSSSnapSize",
@@ -1528,7 +1465,6 @@
{
name: "stop-color",
api_class: "CSSPropertyAPIColor",
- api_methods: ["parseSingleValue"],
converter: "convertColor",
interpolable: true,
svg: true,
@@ -1536,7 +1472,6 @@
{
name: "stop-opacity",
api_class: "CSSPropertyAPIOpacity",
- api_methods: ["parseSingleValue"],
converter: "convertNumberOrPercentage",
interpolable: true,
svg: true,
@@ -1544,7 +1479,6 @@
{
name: "stroke",
api_class: "CSSPropertyAPIPaintStroke",
- api_methods: ["parseSingleValue"],
custom_all: true,
inherited: true,
interpolable: true,
@@ -1554,7 +1488,6 @@
{
name: "stroke-dasharray",
api_class: true,
- api_methods: ["parseSingleValue"],
converter: "convertStrokeDasharray",
inherited: true,
interpolable: true,
@@ -1586,7 +1519,6 @@
{
name: "stroke-miterlimit",
api_class: true,
- api_methods: ["parseSingleValue"],
inherited: true,
interpolable: true,
name_for_methods: "StrokeMiterLimit",
@@ -1596,7 +1528,6 @@
{
name: "stroke-opacity",
api_class: "CSSPropertyAPIOpacity",
- api_methods: ["parseSingleValue"],
converter: "convertNumberOrPercentage",
inherited: true,
interpolable: true,
@@ -1613,7 +1544,6 @@
{
name: "tab-size",
api_class: true,
- api_methods: ["parseSingleValue"],
converter: "convertLengthOrTabSpaces",
inherited: true,
type_name: "TabSize",
@@ -1653,7 +1583,6 @@
{
name: "text-decoration-color",
api_class: true,
- api_methods: ["parseSingleValue"],
custom_all: true,
interpolable: true,
runtime_flag: "CSS3TextDecorations",
@@ -1668,7 +1597,6 @@
{
name: "text-decoration-skip",
api_class: true,
- api_methods: ["parseSingleValue"],
converter: "convertFlags<TextDecorationSkip>",
inherited: true,
runtime_flag: "CSS3TextDecorations",
@@ -1682,7 +1610,6 @@
{
name: "text-indent",
api_class: true,
- api_methods: ["parseSingleValue"],
custom_all: true,
inherited: true,
interpolable: true,
@@ -1706,7 +1633,6 @@
{
name: "text-size-adjust",
api_class: true,
- api_methods: ["parseSingleValue"],
converter: "convertTextSizeAdjust",
inherited: true,
type_name: "TextSizeAdjust",
@@ -1722,7 +1648,6 @@
{
name: "text-underline-position",
api_class: true,
- api_methods: ["parseSingleValue"],
inherited: true,
runtime_flag: "CSS3TextDecorations",
type_name: "TextUnderlinePosition",
@@ -1739,7 +1664,6 @@
{
name: "touch-action",
api_class: true,
- api_methods: ["parseSingleValue"],
converter: "convertFlags<TouchAction>",
type_name: "TouchAction",
},
@@ -1753,7 +1677,6 @@
{
name: "transform-origin",
api_class: true,
- api_methods: ["parseSingleValue"],
converter: "convertTransformOrigin",
interpolable: true,
},
@@ -1764,7 +1687,6 @@
{
name: "translate",
api_class: true,
- api_methods: ["parseSingleValue"],
converter: "convertTranslate",
interpolable: true,
runtime_flag: "CSSIndependentTransformProperties",
@@ -1772,7 +1694,6 @@
{
name: "rotate",
api_class: true,
- api_methods: ["parseSingleValue"],
converter: "convertRotate",
interpolable: true,
runtime_flag: "CSSIndependentTransformProperties",
@@ -1780,7 +1701,6 @@
{
name: "scale",
api_class: true,
- api_methods: ["parseSingleValue"],
converter: "convertScale",
interpolable: true,
runtime_flag: "CSSIndependentTransformProperties",
@@ -1802,7 +1722,6 @@
{
name: "vertical-align",
api_class: true,
- api_methods: ["parseSingleValue"],
custom_inherit: true,
custom_value: true,
interpolable: true,
@@ -1883,7 +1802,6 @@
{
name: "-webkit-box-flex-group",
api_class: true,
- api_methods: ["parseSingleValue"],
type_name: "unsigned int",
},
"-webkit-box-lines",
@@ -1906,7 +1824,6 @@
{
name: "column-gap",
api_class: true,
- api_methods: ["parseSingleValue"],
converter: "convertComputedLength<float>",
custom_all: true,
interpolable: true,
@@ -1914,7 +1831,6 @@
{
name: "column-rule-color",
api_class: "CSSPropertyAPIColor",
- api_methods: ["parseSingleValue"],
custom_all: true,
interpolable: true,
},
@@ -1926,14 +1842,12 @@
{
name: "column-rule-width",
api_class: true,
- api_methods: ["parseSingleValue"],
converter: "convertLineWidth<unsigned short>",
interpolable: true,
},
{
name: "column-span",
api_class: true,
- api_methods: ["parseSingleValue"],
type_name: "ColumnSpan",
},
{
@@ -1945,7 +1859,6 @@
{
name: "-webkit-highlight",
api_class: true,
- api_methods: ["parseSingleValue"],
converter: "convertString<CSSValueNone>",
inherited: true,
},
@@ -1963,7 +1876,6 @@
{
name: "-webkit-line-clamp",
api_class: true,
- api_methods: ["parseSingleValue"],
type_name: "LineClampValue",
},
{
@@ -2001,7 +1913,6 @@
{
name: "-webkit-mask-box-image-source",
api_class: "CSSPropertyAPIImage",
- api_methods: ["parseSingleValue"],
custom_value: true,
interpolable: true,
},
@@ -2087,7 +1998,6 @@
{
name: "-webkit-tap-highlight-color",
api_class: "CSSPropertyAPIColor",
- api_methods: ["parseSingleValue"],
converter: "convertColor",
inherited: true,
},
@@ -2100,7 +2010,6 @@
{
name: "-webkit-text-emphasis-color",
api_class: "CSSPropertyAPIColor",
- api_methods: ["parseSingleValue"],
custom_all: true,
inherited: true,
},
@@ -2112,14 +2021,12 @@
{
name: "-webkit-text-emphasis-style",
api_class: true,
- api_methods: ["parseSingleValue"],
custom_all: true,
inherited: true,
},
{
name: "-webkit-text-fill-color",
api_class: "CSSPropertyAPIColor",
- api_methods: ["parseSingleValue"],
custom_all: true,
inherited: true,
},
@@ -2130,7 +2037,6 @@
{
name: "-webkit-text-stroke-color",
api_class: "CSSPropertyAPIColor",
- api_methods: ["parseSingleValue"],
custom_all: true,
inherited: true,
interpolable: true,
@@ -2138,7 +2044,6 @@
{
name: "-webkit-text-stroke-width",
api_class: true,
- api_methods: ["parseSingleValue"],
converter: "convertTextStrokeWidth",
inherited: true,
},
@@ -2155,7 +2060,6 @@
{
name: "-webkit-transform-origin-z",
api_class: true,
- api_methods: ["parseSingleValue"],
converter: "convertComputedLength<float>",
interpolable: true,
},
@@ -2194,7 +2098,6 @@
{
name: "will-change",
api_class: true,
- api_methods: ["parseSingleValue"],
custom_all: true,
},
{
@@ -2204,7 +2107,6 @@
{
name: "word-spacing",
api_class: "CSSPropertyAPILetterAndWordSpacing",
- api_methods: ["parseSingleValue"],
converter: "convertSpacing",
inherited: true,
initial: "initialLetterWordSpacing",
@@ -2219,7 +2121,6 @@
{
name: "z-index",
api_class: true,
- api_methods: ["parseSingleValue"],
custom_all: true,
interpolable: true,
type_name: "int",
@@ -2245,13 +2146,11 @@
{
name: "max-inline-size",
api_class: "CSSPropertyAPIWebkitMaxLogicalWidthOrHeight",
- api_methods: ["parseSingleValue"],
direction_aware: true,
},
{
name: "max-block-size",
api_class: "CSSPropertyAPIWebkitMaxLogicalWidthOrHeight",
- api_methods: ["parseSingleValue"],
direction_aware: true,
},
@@ -2260,7 +2159,6 @@
{
name: "-webkit-border-end-color",
api_class: "CSSPropertyAPIColor",
- api_methods: ["parseSingleValue"],
direction_aware: true,
},
{
@@ -2274,7 +2172,6 @@
{
name: "-webkit-border-start-color",
api_class: "CSSPropertyAPIColor",
- api_methods: ["parseSingleValue"],
direction_aware: true,
},
{
@@ -2288,7 +2185,6 @@
{
name: "-webkit-border-before-color",
api_class: "CSSPropertyAPIColor",
- api_methods: ["parseSingleValue"],
direction_aware: true,
},
{
@@ -2302,7 +2198,6 @@
{
name: "-webkit-border-after-color",
api_class: "CSSPropertyAPIColor",
- api_methods: ["parseSingleValue"],
direction_aware: true,
},
{
@@ -2332,25 +2227,21 @@
{
name: "-webkit-padding-end",
api_class: "CSSPropertyAPIWebkitPadding",
- api_methods: ["parseSingleValue"],
direction_aware: true,
},
{
name: "-webkit-padding-start",
api_class: "CSSPropertyAPIWebkitPadding",
- api_methods: ["parseSingleValue"],
direction_aware: true,
},
{
name: "-webkit-padding-before",
api_class: "CSSPropertyAPIWebkitPadding",
- api_methods: ["parseSingleValue"],
direction_aware: true,
},
{
name: "-webkit-padding-after",
api_class: "CSSPropertyAPIWebkitPadding",
- api_methods: ["parseSingleValue"],
direction_aware: true,
},
{
@@ -2372,13 +2263,11 @@
{
name: "-webkit-max-logical-width",
api_class: "CSSPropertyAPIWebkitMaxLogicalWidthOrHeight",
- api_methods: ["parseSingleValue"],
direction_aware: true,
},
{
name: "-webkit-max-logical-height",
api_class: "CSSPropertyAPIWebkitMaxLogicalWidthOrHeight",
- api_methods: ["parseSingleValue"],
direction_aware: true,
},
@@ -2392,13 +2281,11 @@
{
name: "page",
api_class: true,
- api_methods: ["parseSingleValue"],
builder_skip: true,
},
{
name: "-webkit-font-size-delta",
api_class: true,
- api_methods: ["parseSingleValue"],
builder_skip: true,
},
{
« no previous file with comments | « third_party/WebKit/Source/build/scripts/templates/CSSPropertyAPIFiles.h.tmpl ('k') | third_party/WebKit/Source/core/css/properties/CSSPropertyAPI.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698