Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Side by Side Diff: third_party/WebKit/Source/build/scripts/make_css_property_apis.py

Issue 2668093003: Revert of Added api_methods flag to CSSProperties.json5. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/build/scripts/templates/CSSPropertyAPIFiles.h.tmpl » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright 2016 The Chromium Authors. All rights reserved. 2 # Copyright 2016 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 import sys 6 import sys
7 7
8 import json5_generator 8 import json5_generator
9 import template_expander 9 import template_expander
10 import make_style_builder 10 import make_style_builder
11 11
12 from collections import namedtuple, defaultdict 12 from collections import namedtuple, defaultdict
13 13
14
14 # Gets the classname for a given property. 15 # Gets the classname for a given property.
15 def get_classname(property): 16 def get_classname(property):
16 if property['api_class'] is True: 17 if property['api_class'] is True:
17 # This property had the generated_api_class flag set in CSSProperties.js on5. 18 # This property had the generated_api_class flag set in CSSProperties.js on5.
18 return 'CSSPropertyAPI' + property['upper_camel_name'] 19 return 'CSSPropertyAPI' + property['upper_camel_name']
19 # This property has a specified class name. 20 # This property has a specified class name.
20 assert isinstance(property['api_class'], str), \ 21 assert isinstance(property['api_class'], str), \
21 ("api_class value for " + property['api_class'] + " should be None, True or a string") 22 ("api_class value for " + property['api_class'] + " should be None, True or a string")
22 return property['api_class'] 23 return property['api_class']
23 24
24 25
25 class CSSPropertyAPIWriter(make_style_builder.StyleBuilderWriter): 26 class CSSPropertyAPIWriter(make_style_builder.StyleBuilderWriter):
26 def __init__(self, json5_file_path): 27 def __init__(self, json5_file_path):
27 super(CSSPropertyAPIWriter, self).__init__(json5_file_path) 28 super(CSSPropertyAPIWriter, self).__init__(json5_file_path)
28 self._outputs = { 29 self._outputs = {
29 'CSSPropertyDescriptor.cpp': self.generate_property_descriptor_cpp, 30 'CSSPropertyDescriptor.cpp': self.generate_property_descriptor_cpp,
30 } 31 }
31 32
32 # Temporary map of API classname to list of propertyIDs that the API cla ss is for. 33 # Temporary map of API classname to list of propertyIDs that the API cla ss is for.
33 properties_for_class = defaultdict(list) 34 properties_for_class = defaultdict(list)
34 for property in self._properties.values(): 35 for property in self._properties.values():
35 if property['api_class'] is None: 36 if property['api_class'] is None:
36 continue 37 continue
37 classname = get_classname(property) 38 classname = get_classname(property)
38 properties_for_class[classname].append(property['property_id']) 39 properties_for_class[classname].append(property['property_id'])
39 self._outputs[classname + '.h'] = self.generate_property_api_h_build er(classname, property['api_methods']) 40 self._outputs[classname + '.h'] = self.generate_property_api_h_build er(classname)
40 41
41 # Stores a list of classes with elements (index, classname, [propertyIDs , ..]). 42 # Stores a list of classes with elements (index, classname, [propertyIDs , ..]).
42 self._api_classes = [] 43 self._api_classes = []
43 44
44 ApiClass = namedtuple('ApiClass', ('index', 'classname', 'property_ids') ) 45 ApiClass = namedtuple('ApiClass', ('index', 'classname', 'property_ids') )
45 for i, classname in enumerate(properties_for_class.keys()): 46 for i, classname in enumerate(properties_for_class.keys()):
46 self._api_classes.append(ApiClass( 47 self._api_classes.append(ApiClass(
47 index=i + 1, 48 index=i + 1,
48 classname=classname, 49 classname=classname,
49 property_ids=properties_for_class[classname] 50 property_ids=properties_for_class[classname]
50 )) 51 ))
51 52
52 @template_expander.use_jinja('CSSPropertyDescriptor.cpp.tmpl') 53 @template_expander.use_jinja('CSSPropertyDescriptor.cpp.tmpl')
53 def generate_property_descriptor_cpp(self): 54 def generate_property_descriptor_cpp(self):
54 return { 55 return {
55 'api_classes': self._api_classes, 56 'api_classes': self._api_classes,
56 } 57 }
57 58
58 # Provides a function object given the classname of the property. 59 # Provides a function object given the classname of the property.
59 # This returned function generates a .h file for the specified property. 60 # This returned function generates a .h file for the specified property.
60 def generate_property_api_h_builder(self, api_classname, api_methods): 61 def generate_property_api_h_builder(self, api_classname):
61 @template_expander.use_jinja('CSSPropertyAPIFiles.h.tmpl') 62 @template_expander.use_jinja('CSSPropertyAPIFiles.h.tmpl')
62 def generate_property_api_h(): 63 def generate_property_api_h():
63 return { 64 return {
64 'api_classname': api_classname, 65 'api_classname': api_classname,
65 'api_methods': api_methods,
66 } 66 }
67 return generate_property_api_h 67 return generate_property_api_h
68 68
69 if __name__ == '__main__': 69 if __name__ == '__main__':
70 json5_generator.Maker(CSSPropertyAPIWriter).main() 70 json5_generator.Maker(CSSPropertyAPIWriter).main()
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/build/scripts/templates/CSSPropertyAPIFiles.h.tmpl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698