Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: extensions/browser/api/declarative_content/content_rules_registry.h

Issue 2668003004: Convert extensions::TabHelper to use the new navigation callbacks. (Closed)
Patch Set: merge with NavigationHandle update Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/declarative_content/content_rules_registry.h
diff --git a/extensions/browser/api/declarative_content/content_rules_registry.h b/extensions/browser/api/declarative_content/content_rules_registry.h
index 239687fa7b72ba7014f7bc8d928269538dfbe537..6bc996836260aa31ed9b662f9e28bf81f7b3db88 100644
--- a/extensions/browser/api/declarative_content/content_rules_registry.h
+++ b/extensions/browser/api/declarative_content/content_rules_registry.h
@@ -13,9 +13,8 @@
namespace content {
class BrowserContext;
+class NavigationHandle;
class WebContents;
-struct FrameNavigateParams;
-struct LoadCommittedDetails;
}
namespace extensions {
@@ -48,10 +47,9 @@ class ContentRulesRegistry : public RulesRegistry {
content::WebContents* contents) = 0;
// Applies all content rules given that a tab was just navigated.
Devlin 2017/02/01 23:18:22 nit: while you're here, mind adding something like
jam 2017/02/01 23:48:49 Done.
- virtual void DidNavigateMainFrame(
+ virtual void DidFinishNavigation(
content::WebContents* tab,
- const content::LoadCommittedDetails& details,
- const content::FrameNavigateParams& params) = 0;
+ content::NavigationHandle* navigation_handle) = 0;
protected:
~ContentRulesRegistry() override {}
« chrome/browser/extensions/tab_helper.cc ('K') | « chrome/browser/extensions/tab_helper.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698