third_party/WebKit/Source/modules/vr/VRDisplay.h - Issue 2668003003: Provide WebVR pose data only to the focused frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/vr/VRDisplay.h

Issue 2668003003: Provide WebVR pose data only to the focused frame. (Closed)

Patch Set: Address comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/vr/VRDisplay.h

diff --git a/third_party/WebKit/Source/modules/vr/VRDisplay.h b/third_party/WebKit/Source/modules/vr/VRDisplay.h

index 7a3d101e1808cb49a6e3c767d55e8fe5c7298cf5..f81dd2bf83180ac552076138c700fcda296bf06f 100644

--- a/third_party/WebKit/Source/modules/vr/VRDisplay.h

+++ b/third_party/WebKit/Source/modules/vr/VRDisplay.h

@@ -92,6 +92,8 @@ class VRDisplay final : public EventTargetWithInlineData,

// ScriptWrappable implementation.

bool hasPendingActivity() const final;

+ void focusChanged();

DECLARE_VIRTUAL_TRACE();

protected:

@@ -148,7 +150,7 @@ class VRDisplay final : public EventTargetWithInlineData,

Member<VREyeParameters> m_eyeParametersLeft;

Member<VREyeParameters> m_eyeParametersRight;

device::mojom::blink::VRPosePtr m_framePose;

- int16_t m_frameId;

+ int16_t m_frameId = -1;

VRLayer m_layer;

double m_depthNear = 0.01;

double m_depthFar = 10000.0;