Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: third_party/WebKit/Source/modules/vr/VRDisplay.cpp

Issue 2668003003: Provide WebVR pose data only to the focused frame. (Closed)
Patch Set: Address comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/vr/VRDisplay.cpp
diff --git a/third_party/WebKit/Source/modules/vr/VRDisplay.cpp b/third_party/WebKit/Source/modules/vr/VRDisplay.cpp
index 4810e4fa6c24817abeabd72c20f1899c1dfaa14f..920bc97c07ef2654e416ddf503d9542f0fef2570 100644
--- a/third_party/WebKit/Source/modules/vr/VRDisplay.cpp
+++ b/third_party/WebKit/Source/modules/vr/VRDisplay.cpp
@@ -114,7 +114,7 @@ void VRDisplay::disconnected() {
}
bool VRDisplay::getFrameData(VRFrameData* frameData) {
- if (!m_framePose || m_displayBlurred)
+ if (!m_focused || !m_framePose || m_displayBlurred)
return false;
if (!frameData)
@@ -128,7 +128,7 @@ bool VRDisplay::getFrameData(VRFrameData* frameData) {
}
VRPose* VRDisplay::getPose() {
- if (!m_framePose || m_displayBlurred)
+ if (!m_focused || !m_framePose || m_displayBlurred)
return nullptr;
VRPose* pose = VRPose::create();
@@ -672,6 +672,8 @@ void VRDisplay::OnVSync(device::mojom::blink::VRPosePtr pose,
}
void VRDisplay::ConnectVSyncProvider() {
+ if (!m_focused)
+ return;
m_display->GetVRVSyncProvider(mojo::MakeRequest(&m_vrVSyncProvider));
if (m_pendingRaf && !m_displayBlurred) {
m_vrVSyncProvider->GetVSync(convertToBaseCallback(
@@ -747,6 +749,15 @@ bool VRDisplay::hasPendingActivity() const {
return getExecutionContext() && hasEventListeners();
}
+void VRDisplay::focusChanged(bool focused) {
+ // TODO(mthiesse): Blur/focus the display.
+ m_vrVSyncProvider.reset();
+ m_focused = focused;
+ if (m_focused) {
+ ConnectVSyncProvider();
+ }
+}
+
DEFINE_TRACE(VRDisplay) {
EventTargetWithInlineData::trace(visitor);
ContextLifecycleObserver::trace(visitor);

Powered by Google App Engine
This is Rietveld 408576698