Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 26680004: flush after every print in windows (Closed)

Created:
7 years, 2 months ago by bsalomon
Modified:
7 years, 2 months ago
Reviewers:
epoger, djsollen, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

flush after every print in windows Committed: http://code.google.com/p/skia/source/detail?r=11670

Patch Set 1 #

Patch Set 2 : bench and gm prints #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M bench/SkBenchLogger.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M gm/gm_expectations.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/ports/SkDebug_win.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bsalomon
7 years, 2 months ago (2013-10-09 14:21:16 UTC) #1
reed1
lgtm
7 years, 2 months ago (2013-10-09 14:21:44 UTC) #2
bsalomon
Post-Mike's lgtm I uploaded patchset 2 which contains additional fflush calls for prints that don't ...
7 years, 2 months ago (2013-10-09 14:28:46 UTC) #3
epoger
LGTM at patchset 2
7 years, 2 months ago (2013-10-09 14:43:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/26680004/4001
7 years, 2 months ago (2013-10-09 14:56:34 UTC) #5
commit-bot: I haz the power
7 years, 2 months ago (2013-10-09 15:09:48 UTC) #6
Message was sent while issue was closed.
Change committed as 11670

Powered by Google App Engine
This is Rietveld 408576698