Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Issue 26680002: Ensure only whitelisted stubs have sse2 versions in the snapshot. (Closed)

Created:
7 years, 2 months ago by oliv
Modified:
7 years, 2 months ago
Reviewers:
mvstanton
CC:
v8-dev
Visibility:
Public.

Description

Ensure only whitelisted stubs have sse2 versions in the snapshot. BUG= R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17123

Patch Set 1 : #

Patch Set 2 : port #

Patch Set 3 : string add is unsafe since it has a double saving centry stub #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -35 lines) Patch
M src/arm/assembler-arm.h View 1 2 chunks +24 lines, -4 lines 0 comments Download
M src/arm/assembler-arm.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/assembler.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/assembler.cc View 1 chunk +3 lines, -8 lines 0 comments Download
M src/code-stubs.h View 1 2 4 chunks +15 lines, -0 lines 0 comments Download
M src/code-stubs.cc View 1 2 4 chunks +9 lines, -8 lines 0 comments Download
M src/ia32/assembler-ia32.h View 1 chunk +25 lines, -4 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips/assembler-mips.h View 1 1 chunk +24 lines, -4 lines 0 comments Download
M src/mips/assembler-mips.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/assembler-x64.h View 2 chunks +25 lines, -4 lines 0 comments Download
M src/x64/assembler-x64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
oliv
This should fix the canary crasher. Port to other platforms is trivial and under way.
7 years, 2 months ago (2013-10-09 10:17:16 UTC) #1
mvstanton
lgtm
7 years, 2 months ago (2013-10-10 08:35:08 UTC) #2
oliv
7 years, 2 months ago (2013-10-10 08:45:49 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r17123 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698