Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Side by Side Diff: chrome/browser/password_manager/chrome_password_manager_client.h

Issue 2667983006: Add HTTP-specific metrics for password forms (Closed)
Patch Set: fix another histogram, add a comment Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/password_manager/chrome_password_manager_client.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_ 5 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_
6 #define CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_ 6 #define CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 const override; 79 const override;
80 PrefService* GetPrefs() override; 80 PrefService* GetPrefs() override;
81 password_manager::PasswordStore* GetPasswordStore() const override; 81 password_manager::PasswordStore* GetPasswordStore() const override;
82 password_manager::PasswordSyncState GetPasswordSyncState() const override; 82 password_manager::PasswordSyncState GetPasswordSyncState() const override;
83 bool WasLastNavigationHTTPError() const override; 83 bool WasLastNavigationHTTPError() const override;
84 bool DidLastPageLoadEncounterSSLErrors() const override; 84 bool DidLastPageLoadEncounterSSLErrors() const override;
85 bool IsOffTheRecord() const override; 85 bool IsOffTheRecord() const override;
86 const password_manager::PasswordManager* GetPasswordManager() const override; 86 const password_manager::PasswordManager* GetPasswordManager() const override;
87 autofill::AutofillManager* GetAutofillManagerForMainFrame() override; 87 autofill::AutofillManager* GetAutofillManagerForMainFrame() override;
88 const GURL& GetMainFrameURL() const override; 88 const GURL& GetMainFrameURL() const override;
89 bool IsMainFrameSecure() const override;
89 const GURL& GetLastCommittedEntryURL() const override; 90 const GURL& GetLastCommittedEntryURL() const override;
90 void AnnotateNavigationEntry(bool has_password_field) override; 91 void AnnotateNavigationEntry(bool has_password_field) override;
91 const password_manager::CredentialsFilter* GetStoreResultFilter() 92 const password_manager::CredentialsFilter* GetStoreResultFilter()
92 const override; 93 const override;
93 const password_manager::LogManager* GetLogManager() const override; 94 const password_manager::LogManager* GetLogManager() const override;
94 95
95 // autofill::mojom::PasswordManagerClient overrides. 96 // autofill::mojom::PasswordManagerClient overrides.
96 void ShowPasswordGenerationPopup(const gfx::RectF& bounds, 97 void ShowPasswordGenerationPopup(const gfx::RectF& bounds,
97 int max_length, 98 int max_length,
98 const base::string16& generation_element, 99 const base::string16& generation_element,
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
193 std::unique_ptr<password_manager::LogManager> log_manager_; 194 std::unique_ptr<password_manager::LogManager> log_manager_;
194 195
195 // Set during 'NotifyUserCouldBeAutoSignedIn' in order to store the 196 // Set during 'NotifyUserCouldBeAutoSignedIn' in order to store the
196 // form for potential use during 'NotifySuccessfulLoginWithExistingPassword'. 197 // form for potential use during 'NotifySuccessfulLoginWithExistingPassword'.
197 std::unique_ptr<autofill::PasswordForm> possible_auto_sign_in_; 198 std::unique_ptr<autofill::PasswordForm> possible_auto_sign_in_;
198 199
199 DISALLOW_COPY_AND_ASSIGN(ChromePasswordManagerClient); 200 DISALLOW_COPY_AND_ASSIGN(ChromePasswordManagerClient);
200 }; 201 };
201 202
202 #endif // CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_ 203 #endif // CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/password_manager/chrome_password_manager_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698