Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2667983005: Fix Fuchsia GN build. (Closed)

Created:
3 years, 10 months ago by rmacnak
Modified:
3 years, 10 months ago
Reviewers:
jamesr1
CC:
jmatt, reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rmacnak
(Broken in https://codereview.chromium.org/2663063006/)
3 years, 10 months ago (2017-01-31 23:19:06 UTC) #2
jamesr1
lgtm
3 years, 10 months ago (2017-01-31 23:21:32 UTC) #3
jamesr1
Thanks for the fast turnaround!
3 years, 10 months ago (2017-01-31 23:21:53 UTC) #4
rmacnak
3 years, 10 months ago (2017-01-31 23:33:04 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
eb5efb31c84e0e895fb6914575b51b675e4fb0d4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698