Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(932)

Unified Diff: ash/common/system/chromeos/ime_menu/ime_list_view.cc

Issue 2667963006: Apply subpixel rendering to labels in cros system menu. (Closed)
Patch Set: docs Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/common/system/tray/tray_popup_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/common/system/chromeos/ime_menu/ime_list_view.cc
diff --git a/ash/common/system/chromeos/ime_menu/ime_list_view.cc b/ash/common/system/chromeos/ime_menu/ime_list_view.cc
index b0c659178cd6647cd3f39c891eafd8d9d2e429d2..f28d0b03c027ac088ce21a79a33ae1e4f65e8332 100644
--- a/ash/common/system/chromeos/ime_menu/ime_list_view.cc
+++ b/ash/common/system/chromeos/ime_menu/ime_list_view.cc
@@ -94,20 +94,13 @@ class ImeListItemView : public ActionableView {
SetLayoutManager(new views::FillLayout);
// The id button shows the IME short name.
- views::Label* id_label = new views::Label(id);
+ views::Label* id_label = TrayPopupUtils::CreateDefaultLabel();
+ id_label->SetText(id);
ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
const gfx::FontList& base_font_list =
rb.GetFontList(ui::ResourceBundle::MediumBoldFont);
id_label->SetFontList(base_font_list);
- // TODO(bruthig): Fix this so that |label| uses the kBackgroundColor to
- // perform subpixel rendering instead of disabling subpixel rendering.
- //
- // Text rendered on a non-opaque background looks ugly and it is possible
- // for labels to given a a clear canvas at paint time when an ink drop is
- // visible. See http://crbug.com/661714.
- id_label->SetSubpixelRenderingEnabled(false);
-
// For IMEs whose short name are more than 2 characters (INTL, EXTD, etc.),
// |kMenuIconSize| is not enough. The label will trigger eliding as "I..."
// or "...". So we shrink the font size until it fits within the bounds.
« no previous file with comments | « no previous file | ash/common/system/tray/tray_popup_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698