Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4996)

Unified Diff: chrome/browser/safe_browsing/prefix_set.h

Issue 266793002: [safe browsing] Serialize full hashes with prefix set. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add a v3 golden test. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/prefix_set.h
diff --git a/chrome/browser/safe_browsing/prefix_set.h b/chrome/browser/safe_browsing/prefix_set.h
index 9a4bbb0780b3d1e765fa3f04b058295444efed92..6471c7361a868afb56c0add777ee517a8c9c5acd 100644
--- a/chrome/browser/safe_browsing/prefix_set.h
+++ b/chrome/browser/safe_browsing/prefix_set.h
@@ -83,7 +83,9 @@ class PrefixSet {
FRIEND_TEST_ALL_PREFIXES(PrefixSetTest, FullHashBuild);
FRIEND_TEST_ALL_PREFIXES(PrefixSetTest, IntMinMax);
FRIEND_TEST_ALL_PREFIXES(PrefixSetTest, OneElement);
+ FRIEND_TEST_ALL_PREFIXES(PrefixSetTest, ReadWrite);
FRIEND_TEST_ALL_PREFIXES(PrefixSetTest, ReadWriteSigned);
+ FRIEND_TEST_ALL_PREFIXES(PrefixSetTest, Version3);
FRIEND_TEST_ALL_PREFIXES(SafeBrowsingStoreFileTest, BasicStore);
FRIEND_TEST_ALL_PREFIXES(SafeBrowsingStoreFileTest, DeleteChunks);
@@ -122,7 +124,9 @@ class PrefixSet {
// Helper for |LoadFile()|. Steals the contents of |index| and
// |deltas| using |swap()|.
mattm 2014/05/01 22:26:51 mention full_hashes?
Scott Hess - ex-Googler 2014/05/05 03:47:07 Done.
- PrefixSet(IndexVector* index, std::vector<uint16>* deltas);
+ PrefixSet(IndexVector* index,
+ std::vector<uint16>* deltas,
+ std::vector<SBFullHash>* full_hashes);
// Top-level index of prefix to offset in |deltas_|. Each pair
// indicates a base prefix and where the deltas from that prefix
« no previous file with comments | « no previous file | chrome/browser/safe_browsing/prefix_set.cc » ('j') | chrome/browser/safe_browsing/prefix_set.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698