[safe browsing] Serialize full hashes with prefix set.

[safe browsing] Serialize full hashes with prefix set.

Persists the entire in-memory representation of the database so that
SBDatabase::ContainsBrowseUrl() will return the same prefix hits after
startup as after the last update.

BUG=172527
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268145

[Scott Hess - ex-Googler, 2014-05-01 21:49:05]

Add a v3 golden test.

[mattm, 2014-05-01 22:26:51]

lgtm with nits

https://codereview.chromium.org/266793002/diff/20001/chrome/browser/safe_brow...
File chrome/browser/safe_browsing/prefix_set.cc (right):

https://codereview.chromium.org/266793002/diff/20001/chrome/browser/safe_brow...
chrome/browser/safe_browsing/prefix_set.cc:305: // Steals contents of |index|
and |deltas| via swap().
update comment

https://codereview.chromium.org/266793002/diff/20001/chrome/browser/safe_brow...
File chrome/browser/safe_browsing/prefix_set.h (right):

https://codereview.chromium.org/266793002/diff/20001/chrome/browser/safe_brow...
chrome/browser/safe_browsing/prefix_set.h:126: // |deltas| using |swap()|.
mention full_hashes?

[Scott Hess - ex-Googler, 2014-05-02 22:32:27]

rely on binary from r267931

[Scott Hess - ex-Googler, 2014-05-05 03:47:06]

OK, seems to work with binary inline.  I should just give up on tries with
binaries, half the time they seem to almost-but-not-quite work...

https://codereview.chromium.org/266793002/diff/20001/chrome/browser/safe_brow...
File chrome/browser/safe_browsing/prefix_set.cc (right):

https://codereview.chromium.org/266793002/diff/20001/chrome/browser/safe_brow...
chrome/browser/safe_browsing/prefix_set.cc:305: // Steals contents of |index|
and |deltas| via swap().
On 2014/05/01 22:26:51, mattm wrote:
> update comment

Done.

https://codereview.chromium.org/266793002/diff/20001/chrome/browser/safe_brow...
File chrome/browser/safe_browsing/prefix_set.h (right):

https://codereview.chromium.org/266793002/diff/20001/chrome/browser/safe_brow...
chrome/browser/safe_browsing/prefix_set.h:126: // |deltas| using |swap()|.
On 2014/05/01 22:26:51, mattm wrote:
> mention full_hashes?

Done.

[Scott Hess - ex-Googler, 2014-05-05 03:47:10]

The CQ bit was checked by shess@chromium.org

[commit-bot: I haz the power, 2014-05-05 03:47:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/shess@chromium.org/266793002/40001

[commit-bot: I haz the power, 2014-05-05 06:19:46]

Change committed as 268145