Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 26679002: Remove HTMLMediaElement.webkitPreservesPitch (Closed)

Created:
7 years, 2 months ago by philipj_slow
Modified:
7 years, 2 months ago
CC:
blink-reviews, nessy, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium, do-not-use
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove HTMLMediaElement.webkitPreservesPitch It is not implemented, so remove it until there is a spec, at which point it can be implemented without a prefix. BUG=305554 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159246

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -19 lines) Patch
M Source/core/html/HTMLMediaElement.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 2 chunks +0 lines, -14 lines 0 comments Download
M Source/core/html/HTMLMediaElement.idl View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
philipj_slow
There's a non-zero compat risk here, since the property is visible and it can be ...
7 years, 2 months ago (2013-10-09 09:52:58 UTC) #1
acolwell GONE FROM CHROMIUM
lgtm
7 years, 2 months ago (2013-10-09 14:26:31 UTC) #2
adamk
I'm not an IDL owner, passing off to eseidel... But I'm curious if we have ...
7 years, 2 months ago (2013-10-09 16:29:13 UTC) #3
eseidel
lgtm remove all teh codez.
7 years, 2 months ago (2013-10-09 16:30:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/26679002/1
7 years, 2 months ago (2013-10-09 16:31:17 UTC) #5
commit-bot: I haz the power
Change committed as 159246
7 years, 2 months ago (2013-10-09 18:11:59 UTC) #6
philipj_slow
7 years, 2 months ago (2013-10-09 18:30:03 UTC) #7
Message was sent while issue was closed.
On 2013/10/09 16:29:13, adamk wrote:
> I'm not an IDL owner, passing off to eseidel...
> 
> But I'm curious if we have any interest in actually implementing
preservesPitch
> in Blink. I believe it's in the spec, and Mozilla has implemented it (I looked
> at this a few months ago and simplified the innards of the code without
removing
> the web-exposed bit).

There's no pitch-related property on HTMLMediaElement:
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element...

I looks Mozilla has indeed added mozPreservesPitch, but the bug
<https://www.w3.org/Bugs/Public/show_bug.cgi?id=15318> they filed to standardize
it was rejected because Hixie thinks you should simply always preserve pitch. If
that isn't what we already do, I guess that would be a start.

Powered by Google App Engine
This is Rietveld 408576698