ios/clean/chrome/browser/browser_coordinator_unittest.mm - Issue 2667873002: [ios clean] Remove stop on Browser coordinator dealloc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/clean/chrome/browser/browser_coordinator_unittest.mm

Issue 2667873002: [ios clean] Remove stop on Browser coordinator dealloc (Closed)

Patch Set: CL Feedback Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/clean/chrome/browser/browser_coordinator_unittest.mm

diff --git a/ios/clean/chrome/browser/browser_coordinator_unittest.mm b/ios/clean/chrome/browser/browser_coordinator_unittest.mm

index c4fabd2f3d336d47aefc65683adc7c8824d1ab65..54fbd76d3747af67909b76e5622927fe1bce93be 100644

--- a/ios/clean/chrome/browser/browser_coordinator_unittest.mm

+++ b/ios/clean/chrome/browser/browser_coordinator_unittest.mm

@@ -50,7 +50,7 @@

namespace {

-TEST(BrowserCoordinatorTest, TestStopOnDealloc) {

+TEST(BrowserCoordinatorTest, TestDontStopOnDealloc) {

__block BOOL called = NO;

{

@@ -60,7 +60,7 @@ TEST(BrowserCoordinatorTest, TestStopOnDealloc) {

};

}

- EXPECT_TRUE(called);

+ EXPECT_FALSE(called);

}

TEST(BrowserCoordinatorTest, TestChildren) {

« no previous file with comments | « ios/clean/chrome/browser/browser_coordinator.mm ('k') | no next file » | no next file with comments »