Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Side by Side Diff: ios/clean/chrome/browser/browser_coordinator.mm

Issue 2667873002: [ios clean] Remove stop on Browser coordinator dealloc (Closed)
Patch Set: Remove stop on Browsercoordinator dealloc Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // ====== New Architecture ===== 5 // ====== New Architecture =====
6 // = This code is only used in the new iOS Chrome architecture. = 6 // = This code is only used in the new iOS Chrome architecture. =
7 // ============================================================================ 7 // ============================================================================
8 8
9 #import "base/logging.h" 9 #import "base/logging.h"
10 #import "ios/clean/chrome/browser/browser_coordinator+internal.h" 10 #import "ios/clean/chrome/browser/browser_coordinator+internal.h"
(...skipping 22 matching lines...) Expand all
33 @synthesize overlaying = _overlaying; 33 @synthesize overlaying = _overlaying;
34 34
35 - (instancetype)init { 35 - (instancetype)init {
36 if (self = [super init]) { 36 if (self = [super init]) {
37 _context = [[CoordinatorContext alloc] init]; 37 _context = [[CoordinatorContext alloc] init];
38 _childCoordinators = [NSMutableSet set]; 38 _childCoordinators = [NSMutableSet set];
39 } 39 }
40 return self; 40 return self;
41 } 41 }
42 42
43 - (void)dealloc {
marq (ping after 24h) 2017/02/01 17:55:14 I'm pretty sure you will need to update the commen
sczs 2017/02/01 18:00:27 Done.
44 [self stop];
45 }
46
47 #pragma mark - Public API 43 #pragma mark - Public API
48 44
49 - (void)start { 45 - (void)start {
50 // Default implementation is a no-op. 46 // Default implementation is a no-op.
51 } 47 }
52 48
53 - (void)stop { 49 - (void)stop {
54 // Default implementation is a no-op. 50 // Default implementation is a no-op.
55 } 51 }
56 52
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 } 116 }
121 117
122 - (void)removeChildCoordinator:(BrowserCoordinator*)coordinator { 118 - (void)removeChildCoordinator:(BrowserCoordinator*)coordinator {
123 if (![self.childCoordinators containsObject:coordinator]) 119 if (![self.childCoordinators containsObject:coordinator])
124 return; 120 return;
125 [self.childCoordinators removeObject:coordinator]; 121 [self.childCoordinators removeObject:coordinator];
126 coordinator.parentCoordinator = nil; 122 coordinator.parentCoordinator = nil;
127 } 123 }
128 124
129 @end 125 @end
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698