Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2373)

Unified Diff: chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc

Issue 2667863005: Mark MediaRouterUIBrowserTest.OpenDialogWithMediaRouterAction flaky (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc
diff --git a/chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc b/chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc
index 9a372f342bd9acb4b06add6ecb231afcb1f5f2ca..63820ad88bbec19c08c9fd740655ba79f418650e 100644
--- a/chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc
+++ b/chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc
@@ -124,8 +124,16 @@ class MediaRouterUIBrowserTest : public InProcessBrowserTest {
MediaRouterActionController* action_controller_ = nullptr;
};
+#if defined(OS_CHROMEOS) || defined(OS_LINUX) || defined(OS_WIN)
+// Flaky on chromeos, linux, win: https://crbug.com/658005
+#define MAYBE_OpenDialogWithMediaRouterAction \
+ DISABLED_OpenDialogWithMediaRouterAction
+#else
+#define MAYBE_OpenDialogWithMediaRouterAction OpenDialogWithMediaRouterAction
+#endif
+
IN_PROC_BROWSER_TEST_F(MediaRouterUIBrowserTest,
- OpenDialogWithMediaRouterAction) {
+ MAYBE_OpenDialogWithMediaRouterAction) {
// We start off at about:blank page.
// Make sure there is 1 tab and media router is enabled.
ASSERT_EQ(1, browser()->tab_strip_model()->count());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698