Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(845)

Unified Diff: build/toolchain/wrapper_utils.py

Issue 2667853004: Remove dependency on scan-build wrapper script for Clang analysis builds. (Closed)
Patch Set: wez feedback Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/toolchain/wrapper_utils.py
diff --git a/build/toolchain/wrapper_utils.py b/build/toolchain/wrapper_utils.py
index 467d85d9e2a74b2dda23be02fe3eda86071d396e..1adbe12fbdd2f7f431960fffc3f5979b3fce34b0 100644
--- a/build/toolchain/wrapper_utils.py
+++ b/build/toolchain/wrapper_utils.py
@@ -92,6 +92,7 @@ def ExtractResourceIdsFromPragmaWarnings(text):
return used_resources
+
Wez 2017/02/03 19:27:55 nit: Spurious extra line!
Kevin M 2017/02/06 17:39:56 Done.
def CaptureCommandStderr(command, env=None):
"""Returns the stderr of a command.

Powered by Google App Engine
This is Rietveld 408576698